two dim table of char*

[rotis23]

Hi All,

Can someone tell me if this is the correct way to create, reference and allocate mem for this data?

int main()
{
	char *char_table[2][1];

	char_table[0][0] = strdup("a string in pos 0,0");
	char_table[0][1] = strdup("a string in pos 0,1");

	char_table[1][0] = strdup("a string in pos 1,0");
	char_table[1][1] = strdup("a string in pos 1,1");
}

Although this works, it's causing memory problems in a bigger program.

Many thanks,

rotis23

[ZuK]

int main()
{
	char *char_table[2][1];

	char_table[0][0] = strdup("a string in pos 0,0");
	char_table[0][1] = strdup("a string in pos 0,1"); // out of bounds

	char_table[1][0] = strdup("a string in pos 1,0");
	char_table[1][1] = strdup("a string in pos 1,1"); // out of bounds
}

use

char *char_table[2][2];

Kurt

[rotis23]

Yes - I have that correct in my other code :/

Is the remaining code valid?

[ZuK]

Yes the code is valid, but you have to free the memory returned by strdup at some point
Kurt

[rotis23]

Thanks for your help Kurt.

[Salem]

Why bother with the strdup (which isn't an ANSI function anyway)

char *table[2][2] = {
  { "this", "is" },
  { "a", "table" },
};