Thread: Simulating the string class - your comments on this, please

'c' is an int. You need this to test for EOF, but, you want to store a char.

Also, you ought to store the return value of realloc in a temporary as Quzah suggested to avoid that problem if it fails.

I'm not operating at 100%, but I might work with this.

Code:

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
   char  *temp, *input = NULL;
   size_t i = 0;
   fputs("Type something: ", stdout);
   fflush(stdout);
   for ( ;; )
   {
      int c = getchar();
      if ( c == '\n' || c == EOF )
      {
         break;
      }
      temp = realloc(input, i + 2/* incoming char and null */);
      if ( temp )
      {
         input = temp;
         input[i++] = c;
         input[i] = '\0';
      }
      else
      {
         free(input);
         break;
      }
   }
   if ( input )
   {
      puts(input);
   }
   free(input);
   return 0;
}

/* my output
Type something: hello world
hello world
*/

Originally Posted by Dave_Sinkula

Code:

      else
      {
         free(input);
         break;
      }
   }
   if ( input )
   {
      puts(input);
   }
   free(input);
   return 0;
}

Skip the free call there, and just break. Or, set 'input' to NULL after the free. (edit: Oh, and move the 'free' call inside the last if check.) Otherwise you'll end up trying to free your pointer twice.

But since we're both not operating at full capacity tonight... (heads off for another brew)

[edit=2]

Originally Posted by cwr

Read my post again. I explain why you don't need sizeof(c).

Hehe. We'll get him eventually.
[/edit]


Quzah.

>input wont be NULL because NULL is never assigned to it.
And if malloc() fails, what will be assigned to it?