Thread: irc socket code

Code:

#include <stdio.h>
#include <stdlib.h>
#include <winsock2.h>

char Heap[1000];

int main(int argc, char *argv[])
{
    int d;
    SOCKET s;
    struct sockaddr_in A;
    WSADATA ws;
    char Buff[1000];
    char aA[13] = "NICK Evander\n";
    char aB[53] = "USER none \"none.com\" \"irc.expression-chat.net\" :none\n";
    char aC[4] = "PING";
    char aD[28] = "PONG :........ing peice of ........\n";
    char aE[12] = "JOIN #help\n";
    char aG[17] = "USERHOST Evander\n";
    
    
        d=WSAStartup(0x101,&ws);
		s=socket(AF_INET,SOCK_STREAM,IPPROTO_TCP);
		A.sin_family=AF_INET;
		A.sin_port=htons(6667);
		A.sin_addr.s_addr= inet_addr("208.53.146.211");
		d=connect(s,(struct sockaddr*)&A,sizeof(A));
		
		send(s,aA,sizeof(aA),0);
		recv(s, Heap, sizeof(Heap), 0);
		printf("Send: %s", aA);
		
		send(s,aB,sizeof(aB),0);
		recv(s, Heap, sizeof(Heap), 0);
		printf("Send: %s",aB);
		
		//send(s,aD,sizeof(aD),0);
		//recv(s, Heap, sizeof(Heap), 0);
		//printf("Send: %s",aD);
		
		send(s,aE,sizeof(aE),0);
		recv(s, Heap, sizeof(Heap), 0);
		printf("Send: %s",aE);
		
		//send(s,aG,sizeof(aG),0);
		//recv(s, Heap, sizeof(Heap), 0); //this is here for some reason
		
		int E = 1;
        int B;
        while (E != 0)
        {
         E = recv(s, Heap, sizeof(Heap), 0);
         if (E >= 0)
         { 
		printf("Recv %s\n", Heap);
		B = memcmp(Heap, aC, 4);
		 if (B == 0)
		  {
               send(s,aD,sizeof(aD),0);
               printf("Send %s", aD);
               HeapClear();             
                                  }
          else HeapClear();
         }
        }
  
  system("PAUSE");
  closesocket(s);
  WSACleanup();	
  return 0;
}
int HeapClear()
{
   int i;
   
   for(i=0; i <= 1000; ++i)
   {
   Heap[i] = 0;
   }
   i = 0;
}

current version is stable,

to implement:

Thread for command input
Rethink of HeapClear (using memset)
Possable switch to using windows api


Help needed in:
Malloc packet handling in memory using pointers
Packet construction ideas
sizeof handling
user input constraints
incomming packet parsing

Eep.

Code:

char aC[4] = "PING";

ohmygosh it's a buffer overflow! Or a compilation error. Just don't specify the size of it if you don't need to. char aC[] = "PING"; Compiler will figure out things nicely for you. Also, try giving things more meaningful variable names (hypocritical comment). I mean with everything having to be initialized at the top, you'll get lost once you scroll down in your code. So about this Heap variable. I don't know, I think you're throwing around buzzwords, but if you really want your data on the heap, you can do the old DMA and:

Code:

char* recvBuf = malloc(1024 * sizeof(char));

Remembering to free() it at the end. You also might rearrange your loop structure to look like:

Code:

while(iRet = recv(s, recvBuf, 1024, 0)) { bleh(); }

And instead of using a function like memcmp, you could just NULL terminate the recv'd string:

Code:

recvBuf[iRet] = 0;

And you can use regular string functions, this would ease your uh, "incomming packet parsing".
memset or ZeroMemory or whatever stupid function you'd like could be implemented with a quick:

Code:

memset(str, 0, 1024);

And I really don't know what the hell you mean by Packet construction ideas, sizeof handling, and user input constraints. Maybe I'm just not too familiar with the grand IRC. To switch to the win32 API, you could just use standard winsock2 functions and you could try Async operations, handling messages, and maybe making a small GUI. Making a thread for "command input" seems somewhat unnecessary and costly, unless you are really doing some crazy stuff with what people are feeding your bot. Check out this small example on how to use threads.

Anyways, feel free to elaborate on your problem? I'm just a bit clueless