strncyp problem

[cboard_member]

Why the fook doesn't this work? I've never had any trouble with strncpy() before. Maybe I'm getting rusty.

 
void init_user_s (user_t* u, int uid, char* uname, char*pwd)
{ 
	u->user_id = uid;
	strncpy (u->username, uname, strlen(uname) + 1);
	strncpy (u->password, pwd, strlen(pwd) + 1);
}

It compiles fine but I get a runtime error. Oh, here's the user_t struct for reference:

typedef struct 
{
	int user_id;
	char* username;
	char* password;
} user_t;

[Salem]

Your pointers in your structure don't point anywhere.
I gues up to now, you've been lucky (that it worked) or unlucky (that it didn't crash the first time you ever made the mistake)

[cboard_member]

Ah very true. Oh and before you do your patented moaning attack, I realise that I spelt strncpy wrong in the title of the thread, and this is the first time I've written a function to initialise a structure, ergo this is the first time I've made this mistake (and it did crash).

This is for after you've locked this thread or whatever:

I knew you were going to do that.

[cboard_member]

Updated code that still doesn't work:

 
/* init_user_s(): initialises a user structure with specified values */
void init_user_s (user_t* u, int uid, char* uname, char* pwd)
{
	uname = (char*)calloc (sizeof(char), strlen(uname) + 1);
	pwd = (char*)calloc (sizeof(char), strlen(pwd) + 1);
 
	if (uid != 1) // user_id 1 reserved for administrator
	{
		printf ("Error, user ID 1 reserved.\n");
		return;
	}
 
	u->user_id = uid;
	strncpy (u->username, uname, strlen(uname) + 1);
	strncpy (u->password, pwd, strlen(pwd) + 1);
}

[Salem]

u->username
Try allocating this

uname is a parameter, which you trash with calloc

Oh, and drop the cast as well - see the FAQ

[cboard_member]

Yeah about the casts, I can't seem to get it to compile if I type something like this:

char* buffer = malloc (sizeof(char) * 10);

If it's easier just post up the FAQ link in question.

[quzah]

Stop compiling as C++. The FAQ isn't hard to find. As a matter of fact, it's right at the top of the page.


Quzah

[cboard_member]

Yes may be true. You seem to be quite good at being sarcastic quzah. I doubt it gets you anywhere in life so don't even bother replying to my threads in future. Can you do that? Appreciate it.

[quzah]

It is true, you idiot. That's why I said it. If you can't compile without a cast, then stop compiling as C++. Furthermore, you're too lazy to click the FAQ link so you want it posted here? WTF? Why am I supposed to believe then that you'll actually read, or click a direct link, when you're too lazy to click FAQ and then scroll down?


Quzah.

[cboard_member]

I realise 'you idiot', that it is easy to get to and it's right there, but some of have a life. Ergo we are doing other things during the time that people like you are clicking links.

WTF? I can't be bothered to read? What did I say above? It was along the lines of fhork off. Yeah, that's better. and don't answer my posts.

[dwks]

You need to include <stdlib.h> to make uncasted malloc() work.