I am reading a book called "C: The complete referente" and the author says that doing something like this is bad programming practice and possibly inefficient.
In my opinion, writing code like that makes it easier to read. What do you guys have to say about this? Thanks.Code:if(strcmp(a, b) == 0) printf("they're equal\n");
It's potentially inefficient, but hardly bad programming practice. How else are you going to do a lexical comparison of two strings? If you write it yourself, it would be the equivalent of strcmp. Then again, since this unnamed author is in fact Herbie Schildt, I would take anything he says with a grain of salt if I were you.
Could you describe in detail what part of that code the book says is bad practice?
My best code is written with the delete key.
> is bad programming practice and possibly inefficient.
And what's his good programming practice and efficient alternative?
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
that code is fine.... depends on the rest of the context in which it is inserted...
>> the author says that doing something like this is bad programming practice and possibly inefficient. <<
Maybe the "bad programming practice" part is the lack of brackets and the "possibly inefficient" part is the use of printf instead of puts?
That would certainly be consistent with Schildt's track record.Originally Posted by anonytmouse
My best code is written with the delete key.
Sure! He wrote a program to divide two numbers like this:
Right after this he wrote that if you write the if command this way,Code:#include <stdio.h> void main(void) /* yes, he uses void main throughout the book! */ { int a, b; printf("Type two numbers: "); scanf("%d%d", &a, &b); if(b) printf("%d\n", a / b); else printf("cannot divide by zero\n"); }
it is redundant, possibly inefficient and bad style.Code:if(b != 0) printf("%d\n", a / b);
It's very outdated advice advocating premature optimization.
http://www.eskimo.com/~scs/C-faq/q5.3.html
7. It is easier to write an incorrect program than understand a correct one.
40. There are two ways to write error-free programs; only the third one works.*
Not mentioning that it's NOT bad style (in fact, my university deducted points for using a integer in a boolean way if it's not meant to be a boolean) and NOT inefficient (unless your compiler really sucks.)
All the buzzt!
"There is not now, nor has there ever been, nor will there ever be, any programming language in which it is the least bit difficult to write bad code."
- Flon's Law
>it is redundant, possibly inefficient and bad style
*stunned silence*
My best code is written with the delete key.
I've just decided something: I'm not reading this book anymore
Luckly I can still send it back and get a refund.
>I'm not reading this book anymore
Good idea. Might I suggest "The C Programming Language" by Kernighan and Ritchie?
My best code is written with the delete key.
I have that one. I am completely in love with that book but the problem is that it's sometimes too advanced for me. I wanted to read a C book to, let's say, get me ready for The C Programming Language. Do you have any suggestions?
It's not too advanced, it just moves quickly and covers a lot of ground. If you work through it then you won't need any book to "get you ready" for K&R. But, some people need their hand held, and for them there's the ACCU. Don't settle for anything less than Highly Recommended or Recommended.
My best code is written with the delete key.
