Count the number of vowels, consonants, digits etc.

Hi! All
Here I am trying to write a programme, which will accept a line of text and count the vowels, consonants, digits, whitespaces & others like (.,;,).
The code i am using is :

Code:

#include<stdio.h>
#include<conio.h>
#include<ctype.h>
void scan_line(char *line, int *pv, int *pc, int *pd, int *pw, int *po);
void main()
{
  char *line;
  int vowels=0;
  int consonants=0;
  int digits=0;
  int whitespace=0;
  int others=0;
  clrscr();
  printf("Enter a line of text below : \n");
  scanf("%s",line);
  printf("%s",line);
  scan_line(line,&vowels,&consonants,&digits,&whitespace,&others);
  printf("\n No. of vowels: %d",vowels);
  printf("\n No. of consonants: %d",consonants);
  printf("\n No. of digits: %d",digits);
  printf("\n No. of whitespace: %d",whitespace);
  printf("\n No. of other characters: %d",others);
getch();
}


void scan_line(char *line, int *pv, int *pc, int *pd, int *pw, int *po)
{
  char c;
  int count=0;
  while((c=toupper(line[count]))!='\n')
  {
    if(c=='A'||c=='E'||c=='I'||c=='O'||c=='U')
       ++*pv;
     else if(c>='A'&& c<='Z')
	++*pc;
     else if(c>='0'&& c<='9')
	++*pd;
     else if(c==' '|| c=='\t')
	++*pw;
     else
	++*po;

   ++count;
   }
   return ;
}

But it is not returning the desired result. 
Please help Anil.

Firstly don't have a void return type for main.

Also,

Code:

  scanf("%s",line);

What are you trying to do here? line is a character pointer that points to a random location - you need to allocate memory to it using malloc() or create a static sized array for writing.

Another problem you will encounter is that you are checking for '\n' using scanf(). scanf() won't actually put the newline character into the string so you are going to go out of bounds in the array checking part. If you insist on using scanf() then check for a nul-byte character '\0' instead of '\n'. A better way to read user input would be to use fgets().

Close!

>#include<conio.h>
There's no need to include this.
1. If you're running in an IDE, clicking on your executable starts with a blank screen anyway, so the first line of clrscr() is well, pointess.
2. The getch(); at the end is also non-portable. Check the FAQ for alternatives.

> void main()
main returns an int

> char *line;
Where is this pointing? Nowhere is the answer.
Input to your program just trashes random bits of memory until the code mysteriously crashes.

char line[100];

> scanf("%s",line);
fgets( line, sizeof line, stdin );
Would be better.

>while((c=toupper(line[count]))!='\n')
Not all input strings are guaranteed to have a newline.
In the first instance, you should check for a \0

Code:

while ( line[count] != '\0' && line[count] != '\n' ) {
  c = toupper( line[count] );

> ++*pv;
You might find that
++(*pv);
or
*pv++;
work better.

Thanx all I have got ur points and implemented ur techniques. Now I have got the appropriate answer too.
Thanx again to all.