String Problem

[recluse]

Hi, i have a string containing " i am a god" and i want to take this array of charecters and split it into four strings(where the spaces are) so the first string is "i" , second is "am" etc... however i am having problems doing this. i am using gcc , however my program is crashing, here is the function i have written to do this, however its not working correctly..... any help is appreciated.

  
    
int split(char *line)
{   
    char splitstring [4][20];
    int charnumber = 0;
    int stringno = 0;
    int a = 0;
    while ( (  line[a] != '\n' ) ){
          if ( line[a] == ' ' ){
              splitstring[stringno][charnumber] = '\0';
              stringno++;
          }
          else{
                splitstring[stringno][charnumber] = line[a];
                a++;
                charnumber++;
          }     
    }
}

line is the array of charecters "i am a god" and i'm trying to split it into an array of strings , therefore

splitstring[0] = "i"
splitstring[1] = "am"

etc..

[Salem]

> stringno++;
reset charnumber back to 0 as well

[recluse]

thanks salem. my while loop was also incorrect because i was checking for a newline when i should have been checking for a '\0'.

[recluse]

i have modified this slightly to check that the array does not go out of bounds, however another problem i am having is that if i input " i am a god" (with more than one space between each word) i am left with strings that contain spaces e.g. splitstring[0] = " i"
splitstring[1] = " am" when i dont want this as later on i have to use string compare on these strings. how do i modify my loop to account for this?

 

int split(char *line, int linecount,int currentline)
{   
    char splitstring [5][20];
    int charnumber = 0;
    int stringno = 0;
    int a = 0;
    while ( line[a] &&  (  line[a] != '\0' ) ){
          if ( ( line[a] == ' ' ) ){
              splitstring[stringno][charnumber] = '\0';
              stringno++;
              charnumber = 0;
              a++;
          }
          if (stringno >= 5) break;
          else{
                splitstring[stringno][charnumber] = line[a];
                a++;
                charnumber++;
                if (charnumber >= 20){
                break;
                charnumber = 0;
                a++;
                stringno++;
                if (stringno >= 5) break;
            }
          }
          //splitstring[stringno][charnumber] = '\0';
              
    }

any help is appreciated. i know that somewhere i need to check whether the next character is also a space (if ive just encountered a space) , however i am not sure where to do this.

[quzah]

How about right where you first find out that you've found a space?

Quzah.

[Salem]

> while ( line[a] && ( line[a] != '\0' ) )
Which is the same as saying
while ( ( line[a] != '\0' ) && ( line[a] != '\0' ) )
Trying to make doubly sure?

A better way would be to do this (it also removes that hacky break statement from your code as well)
while ( stringno < 5 && line[a] != '\0' )

[legend]

i want to take this array of charecters and split it into four strings

why not use strtok?

[recluse]

i have encountered a new problem with the code i posted above, if there is no space after the last string then the last string is not terminated properly , e.g "i eat yellow people" ends up with people not being terminated properly, how can i fix this problem? any help is appreciated!

[Salem]

> how can i fix this problem?
You store a \0 in the correct place

Seriously, this is up to you to fix.

[recluse]

i fixed my problem .thanks .