Thread: Help with my code plz!

Code:

 

#include <stdio.h>
struct numbers
{
	int number[1][4];
}

void calculate (int weeks)

{
	struct numbers week_number[weeks];
	int i=0, x=0, a, b,y;


	do
	{
		for (a=1;a<=2;++a)
		{
			printf("\nFor week %i, game %i, enter the two teams and the score: ",x+1, a);
			scanf("%i%i%i%i", week_number[x].number[1][1], week_number[x].number[1][2], week_number[x].number[1][3], week_number[x].number[1][4]);
			i=i+1;
		}
		x=x+1;

	}while(x!=weeks);

	for (b=0;b>=i;++b)
	{
		printf("\nWeek %i: %i-%i-%i-%i,", b, week_number[b].number[1][1], week_number[b].number[1][2], week_number[b].number[1][3], week_number[b].number[1][4]);
	}
}


main()
{

	int weeks;

	printf("How many weeks of data: ");
	scanf("%i",&weeks);

	calculate(weeks);
}

Its giving me two errors...

1. To many types in declaration (Code Line: void calculate (int weeks))

2. Constant expression required in function calc( Code Line: struct numbers week_number[weeks]

----------------------------
Please help!

Im new to programming.. I've been playing arround with structers and was woundering if i could use matrixes in them...

Is this possible? Whats wrong with my code?

Thanks!

-valt

omg are you serious.. lol Thanks, ill try this when i get at school

Please use more decsriptive titles in future. Something about what error you're getting or what you don't understand helps people see if the thread is about something they can help with.

Code:

#include <stdio.h>


struct numbers
{
	int number[1][4];
	int win;
	int loss;
};



void calc(int weeks)

{

	struct numbers week_number[100][2], team[4];
	int i, week=0, a, game, win_point, loss_point;


	do
	{
		game=1;
		for (a=1;a<=2;++a)
		{
			printf("For week %i, game %i, enter the two teams and the score: ",week+1,a);
			scanf("%i%i%i%i", &week_number[week][game].number[1][1], &week_number[week][game].number[1][2], &week_number[week][game].number[1][3], &week_number[week][game].number[1][4]);
			game=game+1;
		}

		week=week+1;

	}while(week!=weeks);



	for(i=0;i>=4;++i)
	{
		team[i].win=0;
		team[i].loss=0;

		i=i+1;
	}




	week=0;
	do
	{
		for(game=1;game<=2;++game)
		{
			if (week_number[week][game].number[1][3]>week_number[week][game].number[1][4])
			{
				win_point=week_number[week][game].number[1][1];
				loss_point=week_number[week][game].number[1][2];
				team[win_point].win=1+team[win_point].win;
				team[loss_point].loss=1+team[loss_point].loss;
			}
			else
			{
				win_point=week_number[week][game].number[1][2];
				loss_point=week_number[week][game].number[1][1];
				team[win_point].win=(1+team[win_point].win);
				team[loss_point].loss=(1+team[loss_point].loss);
			}
		}

		week=week+1;

	}while(week!=weeks);

	printf("\nLeague Standings after %i weeks: ", weeks);


	for(i=0;i>=4;++i)
	{
		printf("Team %i	%i-%i",i, team[i].win, team[i].loss);
	}
}



int main(void)

{
	int weeks;

	printf("How many weeks of data: ");
	scanf("%i",&weeks);

	calc(weeks);
	return 0;
}

Thanks for all the feedback!

um.. I still cant use weeks for my matrix, number[weeks][2], its not a constant variable or something... so i just made it 100 and it fixed it, but is there any other way so i can have weeks in there instead of 100... Because what if someone wants more then 100 weeks...

Code:

struct numbers week_number[100][2], team[4];

Also, this program compiles, but doesnt display

Code:

	for(i=0;i>=4;++i)
	{
		printf("Team %i	%i-%i",i, team[i].win, team[i].loss);
	}

for some reason..

please help, and thanks again!

And as for your question about changing the size of your matrix, I suggest you do some research (I did all mine with the serach link at the top of this page) on malloc and realloc. Incredibly useful functions when used correctly.

To use malloc() in your example, simply do something along these lines:

From:

Code:

void calculate (int weeks)

{
	struct numbers week_number[weeks];

To:

Code:

void calculate (int weeks)
{
        struct numbers* week_number = malloc(sizeof(struct numbers) * weeks);

If you wanted to have a multi-dimensional array like you did before with [100][2], you can do something like the following:

Code:

for (i = 0; i < 2; i++)
{
        struct numbers* week_numbers[i] = malloc(sizeof(struct numbers) * weeks);
}

Ahh *slaps himself in the face* musta been half asleep when I wrote that