can u guess my number?

Code:

#include <stdio.h>
#include <stdlib.h>

#include <string.h>


int main()
{
	int guess = -1;
	int num = 0;
	int answer;
	int i;
	unsigned seed;
	
	printf{"Enter seed:\n");
	scanf("%d",&seed);

	srand(seed)

		for(i=1;i<=1000,i++); {

	answer = rand() % 100 + 1;

	while ( guess != answer ) {
		num++;
		printf("Enter guess %d: ",num);
		
		if ( guess < answer )
			printf("Too high,try again\n");
		if ( guess > answer ) 
			printf("Too low,try again\n");
	}
	printf("Correct! you guessed the number!\n\n",num);
	}
	
	return 0;
}

im trying to write a number guessing game in C, when trying to run this program i got the following error:

expression evaluates to a function which is missing an argument list

expression evaluates to a function which is missing an argument list
what does that mean and how should i fix it?

Which lines are the errors on?

My guess would be the

Code:

unsigned seed

unsigned what?

Code:

unsigned int seed //?? maybe

unsigned seed is legitimate syntax. The compiler assumes int.

The problem is likely here:

Code:

srand(seed)

See anything missing? It looks like the missing piece fell down to the for() loop. You should take it from there and put it back on that srand() line.

After that you'll have other problems to fix, but let's see if you can take it from here.

Code:

printf{"Enter seed:\n");

And as pointed out...

Code:

   scanf("%d",&seed);

   srand(seed);

   for ( i=1;i<=1000;i++ )/*;*/ {

Originally Posted by itsme86

unsigned seed is legitimate syntax. The compiler assumes int.

Ah, learn something new everyday... Can't believe I missed the semicolon though...

Good show

i fixed the syntax now it runs but infinite numbers and too high,try again scrolls down
when i input 6 as seed

Code:

   int guess = -1;
   /* ... */
      answer = rand() % 100 + 1;
      while ( guess != answer )

Since answer is non negative, and guess is always -1, what would you expect?

my revised code

Code:

#include <stdio.h>
 #include <stdlib.h>
 
 #include <string.h>
 
 
 int main()
 {
 	int guess;
 	int num = 0;
 	int answer;
 	int i;
 	unsigned seed;
 	
 	printf("Enter guess:\n");
 	scanf("%d",&guess);
 
 	srand(guess);
 
 		for(i=1;i<=1000;i++); {
 
 	answer = rand() % 100 + 1;
 
 	while ( guess != answer ) {
 		num++;
 		printf("Enter guess %d: ",num);
		scanf("%d",&guess);
 		
 		if ( guess > answer )
 			printf("Too high,try again\n");
 		if ( guess < answer ) 
 			printf("Too low,try again\n");
 	}
 	printf("Correct! you guessed the number!\n\n",num);
 	}
 	
 	return 0;
 }

i think i got the program to run correctly except

the run result i got was

Enter guess: /* want to eliminate this line */
6
Enter guess 1: 4
Too low,try again
Enter guess 2: 67
Too high,try again
Enter guess 3: 54
Too low,try again
Enter guess 4: 51
Too low,try again
Enter guess 5: 49
Too low,try again
Enter guess 6: 50
Too low,try again
Enter guess 7: 52
Too low,try again
Enter guess 8: 54
Too low,try again
Enter guess 9: 56
Too low,try again
Enter guess 10: 58
Too low,try again
Enter guess 11: 60
Too high,try again
Enter guess 12: 59
Correct! you guessed the number!

Press any key to continue

if i want to revise my program so when the player guess the number in less than 10 tries i want to print out "you're good", do i just add

Code:

if (i=1;i <10;++i)
{
printf("you're good\n");
}

after the printf("Correct! you guessed the number!\n\n",num);
Edit/Delete Message

you already keep track of how many guesses in num
no need for another loop.

just test

if(num < 10)

thx guys

This loop:

Code:

	for(i=1;i<=1000;i++); {

...does nothing for you. You could take that whole line out and its matching brace and you wouldn't even notice a difference in the way your program runs.

Also, in this line of code:

Code:

printf("Correct! you guessed the number!\n\n",num);

Why are you passing num to printf() if the format string doesn't have a place for it?

EDIT: There's also a bug in your program where if the user types the correct random value at the first prompt, the main loop won't even run at all.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>


int main()
{
	int guess=-1;
	int num = 0;
	int answer;
	int i;

	srand((unsigned)time(NULL));

	answer = (rand() % 99)+1;

    while ( guess != answer )
    {
		num++;
		printf("Enter guess %d: ",num);
        scanf("%d", &guess);

		if ( guess > answer )
			printf("Too high.Try again\n\n");

		if ( guess < answer )
			printf("Too low.Try again\n\n");

    }
	printf("Excellent! you guessed the number Would you like to play again (y or n)\n\n",num);
	
	if (num < 10) 
	{
		printf("Either you know the secret or you got lucky\n");
	}
	 else if (num = 10)
	{
		printf("Ahah! You know the secret!\n");
	}
	else
	{
		printf("You should be able to do better\n");
	}

	system("pause");
	return 0;
}

when i guessed the number in the 8th try for some reason it prints out both
"Either you know the secret or you got lucky" and "Ahah! You know the secret!"

Code:

if (num = 10)

Look closely at this. What operator are you using?

if(10 = num)
If you do that, you will get an error at compile time. Which can save you from code that does unexpected things.

If(num = 10)
Will not give you a compile time error, which will not save you.

That is why some people like to put the constant first when comparing.