Help with array

[caduardo21]

#include <stdio.h>

int main()
{
    char a[3][8] = { {"First"}, {"Second"}, {"Third"} };
    
    return 0;
}

How would I display the elements of array a on the screen?

#include <stdio.h>
#include <string.h>

int main()
{
    int i, j;
    char a[3][8] = { {"First"}, {"Second"}, {"Third"} };
    
    for( i = 0; i < 3; i++ ) {
         for( j = 0; j < strlen(a[i]); j++ )
              printf("%s", a[i][j]);
    }
    
    return 0;
}

This does not work. Thanks.

[pianorain]

How about just this:

#include <stdio.h>
#include <string.h>

int main()
{
    int i;
    char a[3][8] = { {"First"}, {"Second"}, {"Third"} };
    
    for( i = 0; i < 3; i++ )
    {
              printf("%s\n", a[i]);
    }
    
    return 0;
}

As a sidenote, you shouldn't use strlen in the condition of a loop. Save the return value of strlen to a temp variable.

[quzah]

As a sidenote, you shouldn't use strlen in the condition of a loop. Save the return value of strlen to a temp variable.

Why? What's your reasoning here? As long as you aren't going to be passing NULL to strlen, what does it matter?

Using the return value of strlen is fine if you do it right. That was just wrong, because they would end up passing it a[3], which would be an invalid array index. That's the real problem. Not the use of the return value for control.


Quzah.

[pianorain]

You don't really want to call strlen every iteration of the loop, do you? Just say NO to strlen.

[quzah]

In a program this size, it's a moot point. As stated, strlen is not the problem. The problem is their array will call strlen with an invalid array index.

Quzah.