Thread: Pass array through functions

thank you very much.

so what if i wanted to get the numbers in the array generated randomly and then returned? i know that foo would have to be an int instead of void..

Code:

array = foo(user_designated_number_for_size);

?

hmm.. that helps. but i was thinking a function more like this:

Code:

int* generate(int number)
{
     int maxrand = 70, random_number[255], counter = 0;
     /* Clear the menu from the screen, multiple menu's annoy me */
     system("cls");
     
     /* create random number */
     do {
     srand( (unsigned)time( NULL ));
     random_number[counter] = rand() % maxrand;
     ++counter;
     } while (counter < number);
     printf("\nRandom number generation completed.\n\n");
     
     /* send the random number back to main */
     return random_number;
}

i'm getting an error saying that the functions returns the address of a local variable which makes sense. so would this be one of those extreme cases to use global variables? because its seeming that they would make this A LOT easier. if not, why? whats bad about global variables? thanks

Changing 1 line in bithub's code

Code:

int* foo(int *array, int arraysize)
{
	int	i;

	/* fill the contents of the array with random numbers */
	for(i = 0; i < arraysize; i++)
		array[i] = rand() % maxrand;

	return array;
}

Yeah except you still can't make an assignment as they're trying to do:

Originally Posted by willc0de4food

so what if i wanted to get the numbers in the array generated randomly and then returned? i know that foo would have to be an int instead of void..

Code:

array = foo(user_designated_number_for_size);

?

You cannot assign arrays. In other words, if this is what you're trying to do, you can't:

Code:

int *foo( ... )
{
    ...
}

...

int main( void )
{
    int array[ BUFSIZ ];

    array = foo( ... );

    return 0;
}

You cannot assign arrays entire values like that. If 'array' were a pointer that you had, in function foo, malloced and filled, then you could return it:

Code:

int *foo( ... )
{
    int *bar;

    bar = malloc( somesize );
    ...

   return bar;
}

int main( void )
{
    int *baz;

   baz = foo( ... );
   ...

    free( baz );
    return 0;
}

This is legal. The first example isn't. Because again, you cannot use the assignment operator (other than at declaration) to assign values to entire arrays.

Quzah.

what does malloc do? also, what does calloc do?

and what about global variables? why are they bad? lol thanks.

lol ok. but that still doesn't say anything about global variables thats what i would really like to know about. lol

iIi c...well what if a global variable would make everything 50% easier? that could be an exaggeration, but i belive it would simplify things greatly - especially considering my skill level is that of a novice.

Originally Posted by willc0de4food

well what if a global variable would make everything 50% easier? that could be an exaggeration, but i belive it would simplify things greatly - especially considering my skill level is that of a novice.

Using global variables can make things appear to be 50% easier as a novice. Unfortunately, this little habit grows with you and when you have more complicated code, it can make things 500% harder to debug (remember that 89.6% of all statistics are made up on the spot). This tradeoff is one of the reasons why the recommendation against using global variables is so prevalent. It also detracts from learning to think in terms of encapsulation and against properly choosing data types.