program hangs during runtime

At runtime, after I type in the name of my executible, it newlines and hangs. I get no error at compile time. I'll post the file I'm reading from if anyone wants it. Is there a problem with the code?

Code:

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>

int main () {
     
     char buf[11];            /* file buffer area */
     int lines, chars, x;    /* count of lines and characters */
     FILE *in;                /* input file stream pointer */

     in = fopen("d5.dat", "r");
    
     if (in == NULL) {
          perror("fopen:     d5.dat");
          exit(1);
     }
           
     fgets(buf, 11, in);
     while(!feof (in)) {
         
          for(x = 0; buf[x] != '\0'; x++)
               if(buf[x] == '\n')
                    lines++;
               if(isalpha(buf[x]))
                    chars++;
     }              
     
     fclose(in);
     printf("\nLines:%d\nCharacters:%d\n\n", lines, chars); 
     return 0;     
}

My guess without seeing your file is that it is longer than 11 characters, hence this:

Code:

while(!feof (in)) {

Never breaks you out of your loop.

The contents of d5.dat:

Code:

Isn't counting lines fun....

You should
see some interesting results.


Be careful to watch for newlines...

Ok I see what your saying.

Ok I figured out what I needed to do, but I get a coredump when I run in UNIX. In Windows, under bloodshed, the executable runs fine. I think the character count is off, but that shouldn't cause a coredump. This is what I got:

Code:

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>

int main () {
     
     char buf[11];	        /* file buffer area */
	 int lines, chars, x;	/* count of lines and characters */
	 FILE *in;		        /* input file stream pointer */

     lines = 0;
     chars = 0;
     in = fopen("d5.dat", "r");
    
     if (in == NULL) {
          perror("fopen:     d5.dat");
          exit(1);
     }
           
     
     while(!feof (in)) {
          
          fgets(buf, 11, in);
          
          for(x = 0; buf[x] != '\0'; x++)
               if(buf[x] == '\n')
                    lines++;
          
          for(x = 0; buf[x] != EOF; x++)
		       if(isalpha(buf[x]))
			        chars++;
     }              
     
     fclose(in);
     printf("\nLines:%d\nCharacters:%d\n\n", lines, chars);
     printf ("Press ENTER to continue.\n");
     getchar ();
     return 0;     
}

> while(!feof (in))
You don't listen - read the FAQ!!!

> for(x = 0; buf[x] != '\0'; x++)
> for(x = 0; buf[x] != EOF; x++)
Spot the difference yet?

Ok made a booboo with EOF. It can't look for EOF in data. Thats big faq to memorize everything, but thanks for showing me. The only prolem I have left is when I do:

Code:

[academ] $ wc d5.dat    
      13      16     115 d5.dat

and then a run my executable, I get 13 lines, but only 102 characters. Should I be using something else instead of isprint?

Code:

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>

int main () {
     
     char buf[11];            /* file buffer area */
    int lines, chars, x;    /* count of lines and characters */
    FILE *in;                /* input file stream pointer */

     lines = 0;
     chars = 0;
     
     if ((in = fopen("d5.dat", "r")) == NULL) {
          perror("fopen:     d5.dat");
          exit(1);
     }     
     
     while(fgets(buf, 11, in) != NULL) {
          
          /* fgets(buf, 11, in); */
                    
          for(x = 0; buf[x] != '\0'; x++)
               if(buf[x] == '\n')
                    lines++;
          
          for(x = 0; buf[x] != '\0'; x++)
               if(isprint(buf[x]))
                    chars++;
     }              
     
     fclose(in);
     printf("\nLines:%d\nCharacters:%d\n\n", lines, chars);
     printf ("Press ENTER to continue.\n");
     getchar ();
     return 0;     
}

wc counts all characters - printable or not.

Perhaps you just need to count the length of each buffer - say using strlen

Cool thanks!