Thread: is the data being read?

I compile my program and it compiles fine...but when I run it..I come up with zero's for all integers and blanks for strings...

can anyone see anything wrong? I at my wits ends and now wondering if the data is even being read properly...

Code:

#include <iostream>
using namespace std;
#include <iomanip.>
#include <stdio.h>
#include <string.h>
#include <cstring>

struct employee 
{
    int id;
    char name[10];
    float pr;
    int csalary;
	int raise;
    double rate;
    int nsalary;
};

void alpha(struct employee *records);
void calc(struct employee *records);
void display(struct employee *records);

main()
{
    char tmp[100];
	struct employee records[14];
	int i=0;
	FILE *fPtr;
	fPtr = fopen("lab2.txt", "r");
	do
	{
		  fgets(tmp,200,fPtr);
		  sscanf(tmp, "%d %s %f %d", &records[i].id, &records[i].name, &records[i].pr, &records[i].csalary);
		}
	while (!(feof(fPtr)));
		printf("ID    Name      PR       Current Salary    $    pct    New Salary    ");
		printf("\n================================================================\n");

	//readfile(records, buf);
	alpha(records);
	calc(records);
	display(records);
	
}

void alpha(struct employee *records)
{
	{
	for(int n=1; n<= 13; n++)
		for (int i=1; i<= 12; i++ )
		{
			int j=i++;
			int result = strcmp ( records[i].name,  records[j].name);
			if ( result > 0 )
				swap( i,j );
		}
	}

}

void calc(struct employee *records)
{
	for (int i=0; i<=12; i++){
		
		if (records[i].pr ==1)
            records[i].rate = 1.045;
        if (records[i].pr ==2)
            records[i].rate = 1.06;
        if (records[i].pr ==3)
            records[i].rate = 1.078;
        if (records[i].pr ==4)
           records[i].rate = 1.09;

        records[i].nsalary = (records[i].csalary*records[i].rate);
        records[i].raise = (records[i].nsalary-records[i].csalary);
        records[i].rate = ((records[i].rate*100)-100);
	}
}

void display(struct employee *records)
{
	for (int i=0; i<=12; i++)
    printf("%d	%s	%.0f		%d	%d	%.2f	%d\n", records[i].id, records[i].name, records[i].pr, records[i].csalary, records[i].raise, records[i].rate, records[i].nsalary);	
}

Bet your wondering why no-one is replying.

Have a look at which forum this is.

Try the C++ forum.

Sorry your coding seems all C but you include the C++ specific header files and using namespace std.

Originally Posted by bigtamscot

Sorry your coding seems all C but you include the C++ specific header files and using namespace std.

yes I know, our teacher says he doesnt matter what we code in. So the headers are basically a default for most programs...

Code:

do
    {
          fgets(tmp,200,fPtr);
          sscanf(tmp, "%d %s %f %d", &records[i].id, &records[i].name, &records[i].pr, &records[i].csalary);
        }

you do not increment (i) in the loop so element 0 of your array of records is changing in each loop.

Thats just for starters.

Originally Posted by bigtamscot

Thats just for starters.

oh boy...

Code:

	for (i=0;i<=14;i++);
	do{
		  fgets(tmp,200,fPtr);
		  sscanf(tmp, "%d %s %f %d", &records[i].id, &records[i].name, &records[i].pr, &records[i].csalary);
		}

Also you declare tmp as a character array to hold 100 elements (100 bytes of memory) and then read a file at 200 bytes. Just asking for trouble.

Originally Posted by bigtamscot

Also you declare tmp as a character array to hold 100 elements (100 bytes of memory) and then read a file at 200 bytes. Just asking for trouble.

yes you are right, I was tweaking numbers around and never changed that one...thanks

here is a tutorial on I/O http://www.cprogramming.com/tutorial/lesson10.html

> our teacher says he doesnt matter what we code in
Your teacher is just as clueless as the class then - no wonder you're having so many problems.

Code:

    do
    {
          fgets(tmp,200,fPtr);
          sscanf(tmp, "%d %s %f %d", &records[i].id, &records[i].name, &records[i].pr, &records[i].csalary);
        }
    while (!(feof(fPtr)));

1. You LIE to fgets about the size of the buffer it has.
2. You use !feof() - see the FAQ
3. You ignore all status returns.
4. You don't increment your index variable.

Code:

while ( i < 14 && fgets(tmp,sizeof tmp,fPtr) != NULL ) {
    if ( sscanf( sscanf(tmp, "%d %s %f %d", &records[i].id, &records[i].name, &records[i].pr, &records[i].csalary) == 4 ) {
        i++;
    } else {
        fprintf( stderr, "Bad record: %s\n", tmp );
    }
}

Of course, the 14 should be a #define CONSTANT which is also used in the size of your array.