Thread: Please Help!

I wrote this program with user defined fuctions to roll a visual dice. I am a newbie so please tell me what am I doing wrong.

Thanks

Code:

#include <stdio.h>
#include <time.h>
#include <stdlib.h>
#include <ctype.h>

char getans();
int randn(int n);
void printBLine(int n);

int main()
 {
   

   ans = getans();
   srand(time(0));


int randn(int n)

   int r = 0 ;
   char ans = 0 ;
   int i = 0 ;
   int numOfBLine;

   while(ans== 'y')
    {
      r = rand()% 6 + 1 ;

      
      switch (n)
      {
        case 1 : printf("\n * \n"); 
                      break;
        case 2 : printf(" * \n");
                      printf(" * \n");   
                       break;
        case 3 : printf("*   \n");
                      printf(" *  \n");
                      printf("  * \n");  
                      break;
        case 4 :  printf(" * * \n\n");
                      printf(" * * \n"); 
                      break;
        case 5 : printf(" * * \n");
                      printf("  *  \n");
                      printf(" * * \n"); 
                     break;
        case 6 : for(i=0 ; i<3 ; i++)
                         printf(" * * \n");
                     break;
      }  /*endSwitch */
     
      printBLine();
       ans = getans();
    }

    /* write blank lines */
    printBLine();
     return n;
}

char getans()
 {
   int ans = -1 ;
   printf("Throw y/n ?");
   while (ans == -1)
    {
      ans = getchar( );
      ans = tolower(ans);
    }
   fflush(stdin); 
   return ans;
}



/* write blank lines */
int printBLine(int n)

	{
      int i=0;
      for(i=0 ; i< numOfBL ; i++) 
            printf("\n");
	return n;
	
	}

sorry, I declared "ans" in the main function, and I closed the braces for main function.

It still gives me error.

says:

r, ans, and i not initailized.

What does this means?

edit: And says syntax error before while

Thanks

If you declare all your variables in main, you won't be able to use them in any other function. Declare the variables that need to be global in the same place you put your function prototypes before main.

In your two while loops, you first use ans as a char, and then later as a numerical value. That's going to be a problem, but in the meanwhile, ans is still being used out of scope - that'll be fixed if you follow the above paragraph.

ok here is the code again that I fixed a little, but I am getting a error again. I declared the variables locally.

Code:

#include <stdio.h>
#include <time.h>
#include <stdlib.h>
#include <ctype.h>

char getans();
int randn(int n);
void printBLine(int n);

int main()
 {
   int dice;
   char blank;
   int ans;
   
   ans = getans();
   blank=printBLine();
   dice=randn();
   srand(time(0));
   
 }

int randn(int n)

 {
   int r = 0 ;
   char ans = 0 ;
   int i = 0 ;
   

   while(ans== 'y')
    {
      r = rand()% 6 + 1 ;

      
      switch (n)
      {
        case 1 : printf("\n * \n"); 
                      break;
        case 2 : printf(" * \n");
                      printf(" * \n");   
                       break;
        case 3 : printf("*   \n");
                      printf(" *  \n");
                      printf("  * \n");  
                      break;
        case 4 :  printf(" * * \n\n");
                      printf(" * * \n"); 
                      break;
        case 5 : printf(" * * \n");
                      printf("  *  \n");
                      printf(" * * \n"); 
                     break;
        case 6 : for(i=0 ; i<3 ; i++)
                         printf(" * * \n");
                     break;
      }  /*endSwitch */
     
      printBLine();
       ans = getans();
    }

    /* write blank lines */
    printBLine();
     return n;
}


char getans()

 {
   int ans = -1 ;
   printf("Throw y/n ?");
   while (ans == -1)
 {
      ans = getchar( );
      ans = tolower(ans);
 }
   fflush(stdin); 
   return ans;
}



/* write blank lines */
int printBLine(int n)

	{
      int i=0;
      for(i=0 ; i< numOfBL ; i++) 
            printf("\n");
	return n;
	
	}

Now is says conflict with printBLine() fucntion

thanks

I declared the variables locally.

Well you set ans equal to the return value of getans, but that value is never used. Probably because you're not paying any attention to the scope of your variables and what they're used for.

As far as I can tell, the problems in your printBLine() function is that you use numOfBL, which is not defined. Do you mean to use n instead?

thanks guys....I tried that too....for some reason it still doesn't work....well anyways I am going to bed now....I give up for today ....I will work on it tommrow now.....Thanks for all the help