Thread: binary search program

this is a code for the binary search program in c language.now the program is not showing any error but when i run this program then the output is like:
enter the total numbers:6
enter the array elements: 5 4 7 1 3 2
the sorted numbers are:1 2 3 4 5 7
enter the number to be searched:5
then it prints::::the number is not found
now why does it always print the number is not found no matter what number i enter.it always show "the number is not found"????why?????it is printing the sorted list alright.so why not the number then?plz help me out!!!!!!!!

Code:

#include<stdio.h>
#include<conio.h>
void main()
{
int a[10],n,i,j,temp;
int beg,end,mid,target;
clrscr();
printf(“enter the total numbers:”);
scanf(“%d”,&n);
printf(“enter the array elements:” );
for(i=0;i<n;i++)
scanf(“%d”,&a[i]);
for(i=0;i<n-1;i++)
    {  
     for(j=0;j<n-i-1;j++)
       {
          If(a[j+1]<a[j])
            {
               temp=a[j];
                a[j]=a[j+1];
                 a[j+1]=temp;
            }
      }
  }
printf(“the sorted numbers are:”);
for(i=0;i<n;i++)
printf(“%4d”,a[i]);
beg=a[0];
end=a[9];
mid=(beg+end)/2;
printf(“\nenter the number to be searched:”);
scanf(“%d”,&target);
while(beg<=end && a[mid]!=target)
{
if(target<a[mid])
 end=mid-1;
else
beg=mid+1;
mid=(beg+end)/2;
}
If(a[mid]==target)
  {
printf(“\nthe number is found at position %2d”,mid);
  }
else
    {
printf(“\nthe number is not found:”);
     }
getch();
}

i m not able to understand here....what exactly do u want m,e to try?
could u plz make some necessary changes in my code....in order to make it run properly and what all i have been lacking there?plz help me out .......?

Hi,

Code:

beg=a[0];
end=a[9];
mid=(beg+end)/2;
printf(“\nenter the number to be searched:”);

In the above code, use n-1 instread of 9. because it will affect the Binary search Logic if you used less or more than 10 input values.

Code:

if(a[mid]==target)
  {
printf("\nthe number is found at position %2d",mid);
  }
else
    {
printf("\nthe number is not found:");

Use (mid+1) while printing the position.

Note:: Output Verified .