Thread: lites (debug error )

hello to all programmers

syntaxe is ok ...

but when i enter the number of element list then i enter the first number ---> debug error !!

here is my code

Code:

#include <stdlib.h>
#include <conio.h>
#include <stdio.h>

typedef struct cellule
{
int info;
cellule *suivant;

}cellule, *liste;



/******************************************************************/
liste nouveau(){return NULL; }
/******************************************************************/
liste suivant(liste p){ return(p->suivant); }
/******************************************************************/
int debut(liste l){  return l->info ; }
/******************************************************************/

void afficher(liste tete)
{
liste p;
p=tete;
printf("\n\n");
printf("\n-----------------------------------------------------\n");
while(p!=NULL)
{
printf(" %d", p->info );
p=suivant(p);
}
printf("\n-----------------------------------------------------\n");


}

liste ajoutfin(liste l, int a )
{

liste p1,p2;

liste N=(liste)malloc(sizeof(liste));

if (N!=NULL)
{
	N->info=a;
	N->suivant=NULL;
}


liste remplir_tete(liste p)
{

int n,a;

printf("Entrer le nombre d'elements de la liste: ");scanf("%d",&n);


for(int i=0; i<n ; i++)
{
  printf("Entrer l'element %i: \n",i+1);
  scanf("%i",&a);
 p=ajoutfin(p,a);
return(p);
}


int main()
{
liste l;

l=nouveau();
printf("saisie liste 1 --> remplir_tete\n");
l=remplir_tete(l);
afficher(l);
return(1);
}

----------------------------------------
thanks for help ...

> syntaxe is ok ...
Erm, no it isn't

> iste ajoutfin(liste l, int a )
There is no 'iste' and it's braces are unbalanced.

> t=nouveau();
t is undeclared.

And your indentation sucks.

> liste remplir_tete(liste p)
Try ending this function with
return p;

> liste N=(liste)malloc(sizeof(liste));
Read the FAQ - there's no reason why you should be casting malloc in C.

You sure are an impatient little troll aren't you

No, include all your header files, and indent it properly

You shouldn't cast the return value of malloc().

Code:

char *ptr = malloc(5);

...works just fine.

>> now it's ok my code

well, in addition to what's already been said, you're not appending the data to the end of the list. the return statement in remplir_tete() doesn't make much sense either.

Now that's what I call indentation - learn to do something like it enjoy

Code:

#include <stdlib.h>
/*#include <conio.h> NOT NEEDED */
#include <stdio.h>

typedef struct cellule {
    int info;
    struct cellule *suivant;    /* ADDED struct - make C++ code into C code */
} cellule, *liste;


liste nouveau()
{
    return NULL;
}

liste suivant(liste p)
{
    return (p->suivant);
}

int debut(liste l)
{
    return l->info;
}

void afficher(liste tete)
{
    liste p;
    p = tete;
    printf("\n\n");
    printf("\n-----------------------------------------------------\n");
    while (p != NULL) {
        printf(" %d", p->info);
        p = suivant(p);
    }
    printf("\n-----------------------------------------------------\n");
}

liste ajoutfin(liste l, int a)
{
    /* liste p1, p2; - REMOVED USELESS VARS */
    liste N = malloc(sizeof(cellule));  /* REMOVE CAST, USE CORRECT TYPE */
    if (N != NULL) {
        N->info = a;
        N->suivant = l;         /* USE parameter to link into existing list */
    }
    return N;                   /* ADDED THIS */
}                               /* ADDED THIS */

liste remplir_tete(liste p)
{
    int i;                      /* MOVED FROM for loop, making code C (not C++) */
    int n, a;

    printf("Entrer le nombre d'elements de la liste: ");
    scanf("%d", &n);
    for (i = 0; i < n; i++) {
        printf("Entrer l'element %i: \n", i + 1);
        scanf("%i", &a);
        p = ajoutfin(p, a);
    }
    return (p);                 /* MOVED OUTSIDE FOR LOOP !!! */
}                               /* ADDED THIS */

int main()
{
    liste l;
    l = nouveau();
    printf("saisie liste 1 --> remplir_tete\n");
    l = remplir_tete(l);
    afficher(l);
    return (0);                 /* SUCCESS IS 0, not 1 */
}

And for heavens sake, learn the difference between C and C++

Hehe.. Salem isnt making it easy for us noobs