Some problems

Hello, i tried do some excerises from a book i have, one exercise says to create a program tha you will enter 3 numbers and it will print the biggest and then the 2s biggest and the 3th biggest
for example if you add 8 9 1 it should print
8
9
1
so i did this:

Code:

#include <stdio.h>

main()
{
        int ga, ga2, ga3;

        printf("Write 3 numbers: \n");
        scanf("%i %i %i", &ga, &ga2, &ga3);
        if (ga> ga2 > ga3)
        {
                printf("The numbers are: %i %i %i\n", ga, ga2, ga3);
        }
        if (ga3 > ga2 > ga)
        {
                printf("The  numbers are: %i %i %i\n", ga3, ga2, ga);
        }
        if (ga < ga2 <ga3)
        {
                printf("The numbers are: %i %i %i\n", ga2, ga, ga3);
        }
}

but it doesn't work


in the same book i also got an exercise to create a program that when you insert a number betwwen 1 - 7 it will print the days of the week, i could do that by easy with case and swtch but it need if-else
so i did this:

Code:

#include <stdio.h>
/* Apo askisi 6 selida 81*/
main()
{
        int numb;
        printf("Write a number: \n");
        scanf("%d", &numb);
        if (numb = '1')
        {
                printf("Deutera\n");/*means monday*/
        }
        else
        {
        if(numb = '2')
        {
                printf("Triti\n");/*means thirday*/
        }
        }
        else
        {
        if(numb = '3')
        {
                printf("Tetarti\n");/*means thirsday*/
        }
        }
        else
        {
        if(numb = '4')
        {
                printf("Pempti\n");/*means thusday*/
        }
        }
        else
        {
        if(numb = '5')
        {
                printf("Paraskeui\n");/*means friday*/
        }
        }
        else
        {
        if(numb = '6')
        {
                printf("Sabbato\n");/*means saturday*/
        }
        }
        else
        {
 {
        if(numb = '6')
        {
                printf("Kiriaki\n");/*means sunday*/
        }
       }
}

doens't work thoyght
please help me

Perhaps you should go back and read up on the logical operators. Hell, go back and read up on ALL the operators covered so far. Because you seem to have forgotten the very basics:

= is for assignment.
== is for equality.

AND a few otherthings. Do it now OR you'll have severe problems in everything you do related to programming.

Quzah.

>if (ga> ga2 > ga3)
These tests don't work like you would expect. It's the same as:

Code:

int a = ga > ga2;
if (a > ga3)

ga3 is tested against a boolean value, which isn't what you want, I would wager. The correct test would be:

Code:

if (ga > ga2 && ga2 > ga3)

>if (numb = '1')
= is assignment, == is comparison.

Use a switch for the second code , it'll make it much easier.

ok, will try again

hey brain-cell
you must read the whole topic(don't be bored)

i could do that by easy with case and swtch but it need if-else

>Use a switch for the second code , it'll make it much easier.

Originally Posted by cogeek

i could do that by easy with case and swtch but it need if-else

Though, a switch still isn't an optimal solution. A table based approach is better, but these are beginner's problems, so I didn't introduce it.

Originally Posted by cogeek

Hello, i tried do some exercises from a book i have, one exercise says to create a program tha you will enter 3 numbers and it will print the biggest and then the 2s biggest and the 3th biggest
for example if you add 8 9 1 it should print
8
9
1

Certainely not. You probably meant :
9
8
1

so i did this:

Code:

        int ga, ga2, ga3;

        scanf("%i %i %i", &ga, &ga2, &ga3);
        if (ga> ga2 > ga3)
        {

but it doesn't work

C expressions doesn't work like that. You must use two operands and a comparision operator in-between:

Code:

operand1 operator operand2

For example:

Code:

        if (ga> ga2)

If you have several expressions, you have to combine them using the same pattern :

Code:

        if (ga> ga2  && ga2 > ga3)

in the same book i also got an exercise to create a program that when you insert a number betwwen 1 - 7 it will print the days of the week, i could do that by easy with case and swtch but it need if-else
so i did this:

Code:

        int numb;
        scanf("%d", &numb);
        if (numb = '1')

doens't work thoyght
please help me

You are confusing the digit characters '1', '2' etc. and the numerical values 1, 2 ... Remove the ' '. Also, the comparision operator is '==' and not '=' (assignment).

(BTW, you have an [edit]) button to correct the typos on your post... I know that English is not your first language, it's not mine either).

hey when i added 2 == i got the same error when compiling:
daysif.c: In function `main':
daysif.c:19: parse error before "else"
ok, i will try without the 'x'

Originally Posted by Prelude

>Use a switch for the second code , it'll make it much easier.

Though, a switch still isn't an optimal solution. A table based approach is better, but these are beginner's problems, so I didn't introduce it.

And it was precisely demanded to use 'if' rather than 'switch'. (Well, I guess : )

i could do that by easy with case and swtch but it need if-else

hey , i delete the ' and added == instead = but still nothing in the days program

Originally Posted by cogeek

hey when i added 2 == i got the same error when compiling:
daysif.c: In function `main':
daysif.c:19: parse error before "else"
ok, i will try without the 'x'

You have too many '}'. You should work on your indentation (or use an indenter). It makes things easier.

Originally Posted by cogeek

hey , i delete the ' and added == instead = but still nothing in the days program

This is meaningless. You must copy and paste the error messages from you development system. We are not psychic.

hey emmanuel:
you must not be psychic just read the whole TOPIC:

Today, 07:35 PM
hey when i added 2 == i got the same error when compiling:
daysif.c: In function `main':
daysif.c:19: parse error before "else"
ok, i will try without the 'x'

and i get the same eroors without '

Welcome to your fifth red. There's a reason you get those. That reason is: YOU DON'T LISTEN. Why on earth should we bother helping you if you don't listen?

So which ' did you remove? You have a whole bunch in your code. That's the reason people tell you to post your latest attempt. I'm done helping you. You have no desire to learn, nor do you listen. Good bye.

Quzah.

>you must not be psychic just read the whole TOPIC
Maybe you should read the whole topic:

Originally Posted by Emmanuel Delaha

You have too many '}'.

Your attitude isn't endearing you to us, so it would be a good idea to think before you type.