This must be simple

**SpudNuts** · 12-13-2004

I'm just trying to get this code to print but it won't compile and I just can't see it, alittle help?

Code:

#include <stdio.h>

void mystery(char *str)
{
	if(*str != '\0')
	{
		mystery(str + 1);
		printf("%s\n", str);
	}
}
mystery("abcd");

Thanks

**sean** · 12-13-2004

Is this your entire source code? Where is your main function? You also appear to have an incorrect understanding of how C-strings work. What exactly do you want your program to do? Please remember to always include exactly what errors, warning, and/or other message you get when your code does not compile.

**SpudNuts** · 12-13-2004

Yeah, that's all of it, well, I think it is.

The errors I get are:

error C2501: 'mystery' : missing storage-class or type specifiers
error C2365: 'mystery' : redefinition; previous definition was a 'function'
error C2440: 'initializing' : cannot convert from 'const char [5]' to 'int' This conversion requires a reinterpret_cast, a C-style cast or function-style cast

**linuxdude** · 12-13-2004

you can't call a function outside of main it thinks you are trying to reinitialize it. There are your first 2 errors. The last one we can't tell, because we don't have all the code.

**sean** · 12-13-2004

Every program needs a main function - it's where the computer will start executing your program.

Code:

int main(int argc, char *argv[])
{
// ... your main execution code
}

The return type of main should be an int. Some people use void main, but some people are losers. All the stuff in parentheses is how you can get parameters into your program from the OS. You can leave this blank if you want to. Just be aware that it's there, as some people will use it.

You can have all of your mystery() functions code written before your main function, or you can write it after. If you write it after, you need to add your function's prototype (void mystery(char *str)) followed by a semicolon above your main function.

Inside your main function, you can make your function call to mystery(). That should get the code to compile. It does not necessarily make your mystery function work, however.

edit - nevermind what I said about strings in my last post.

**SpudNuts** · 12-18-2004

Got it

Code:

#include<stdio.h>

void Mystery(char *);

int main(void)
{
    Mystery("abcd");
}

void Mystery(char* Str)
{
    if (*Str != '\0')
    {
        Mystery(Str + 1);
        printf("%s\n",Str);
    }
}

**misplaced** · 12-18-2004

unless it's for educational purposes, i suggest not using recursion.
you could get the same effect with

Code:

#include<stdio.h>

void Mystery(char *);

int main(void)
{
    Mystery("abcd");
}

void Mystery(char* Str)
{
    while(*Str != '\0')
    {
          printf("%s\n",Str);
          Str++;
    }
}

**Thantos** · 12-18-2004

actually yours and SpudNuts' produce different results misplaced:
Mystery1 = SpudNuts
Mystery2 = misplaced

Code:

#include<stdio.h>

void Mystery1(char *);
void Mystery2(char *);

int main(void)
{
    puts("First:");
    Mystery1("abcd");
    puts("\nSecond:");
    Mystery2("abcd");
    return 0;
}

void Mystery1(char* Str)
{
    if (*Str != '\0')
    {
        Mystery1(Str + 1);
        printf("%s\n",Str);
    }
}



void Mystery2(char* Str)
{
    while(*Str != '\0')
    {
          printf("%s\n",Str);
          Str++;
    }
}

output

First:
d
cd
bcd
abcd

Second:
abcd
bcd
cd
d

Mine:

Code:

void Mystery3(char* Str)
{
  char *end = NULL;
  for(end = Str; *end != '\0'; end++);
  for(end--; end >= Str; end--)
    puts(end);
}

**misplaced** · 12-18-2004

my bad....i didn't unwind the stack in my head..either than or i was thinking mystery was called before printf

**Thantos** · 12-19-2004

Heh I think the only reason I caught it was because I had to write a recursive str_rev() function for my C++ final. This basically does the same just the print it different.

**misplaced** · 12-19-2004

my question is, why isn't there a std str rev function (pre c++)?

or is there and i've completely missed it somehow?

**Thantos** · 12-19-2004

Why ask why, try bud dry

**Prelude** · 12-19-2004

>why isn't there a std str rev function (pre c++)?
Because it's dead easy to write, and not as useful as the other string handling functions (in the standard library) that are also dead easy to write.

Thread: This must be simple

Thread Tools

Search Thread

Display

This must be simple

Similar Threads

creating very simple text editor using c

Simple message encryption

Binary Search Trees Part III

Simple simple program

Need help with simple DAQ program