Thread: c program on grades of a student

hi
i have tried to do this c program but i have checked alot of times but it is still giving me 3 errors, like unterminated string or character constant ,function call missing ,statement missing,so plz tell me what's wrong in it?
it should print fail when the average marks 0f 5 subjects are between 0 to 39;third division when the average marks of a student are between 40 to 49;second division when 50 to 59;first division when 60 to 79;it should print honours when the average marks are between 80 to 100.
so i did like this:


#include<stdio.h>
#include<conio.h>
void main()
{
float eng,maths,de,it,c,avmar;
printf("enter the marks for english:");
scanf("%f",&eng);
printf("enter the marks for maths:");
scanf("%f",&maths);
printf("enter the marks for digital electronics:");
scanf("%f",&de);
printf("enter the marks for information technology:");
scanf("%f",&it);
printf("enter the marks for c:");
scanf("%f",&c);
avmar=(eng+maths+de+it+c)/5;
printf("the average marks are=%f",avmar);
if((avmar<39)&&(avmar>0))
printf("fail");
else if((avmar<49)&&(avmar>40))
printf("third division");
else if((avmar<59)&&(avmar>50))
printf("second division");
else if((avmar<79)&&(avmar>60))
printf("first division");
else ((avmar<100)&&(avmar>80))
printf("honours");
getch();
}
now what's wrong in it?
the compiler is showing error in line 14 as unterminated string or character constant?what do we mean by that?
and in line 15 an d 27....
im completely puzzeled by this....
guys plz help me out..........
have i written the corrct program........?

Having told you to read THIS
http://cboard.cprogramming.com/showthread.php?t=25765
before posting code, guess what - you didn't

Doesn't your compiler tell you what line number the problem is on? It's on line 17:

printf("the average marks are="%f",avmar);

Count the quotes...

Originally Posted by galmca

iam waiting guys plz help me out!!!!!! i'll be reallly greatful to u.......im stuck in this program for a very long time.....even though it seems correct to me.....why is showing an error in line 14 as unterminated string or character constant ?what does it mean?and alos in line 15 and 27.......
plz help me out.....

The code at the top of this thread (edited by you about 20 minutes ago as I post this) has one compilation error: missing semicolon in line 27.

I told you where to look.

Did you look there?

Regards,

Dave

>i have looked everywhere but ican't find anything wrong anywhere

Code:

   else if ((avmar<100)&&(avmar>80))

Originally Posted by galmca

i have looked everywhere but ican't find anything wrong anywhere..........
every line i have looked into.......
plz dave help me out........
and also tell me why is it giving me an error in line 14 as unterminated string or character constant.....even though it is correct.....

I don't get an error in line 14. Post the code again.

[edit]
Never mind; I'll do it
[/edit]

As for line 27 Here are a few lines around line 27:

Code:

else if((avmar<79)&&(avmar>60))
printf("first division");
else ((avmar<100)&&(avmar>80))
printf("honours");

This is line 26

Code:

else ((avmar<100)&&(avmar>80))

You probably meant

Code:

else if ((avmar<100)&&(avmar>80))

Now this is unnecessary logic, and line 26 could simply be

Code:

else

The fact is, however, your program would be syntactically correct if line 26 had a semicolon.

I sense your frustration (believe it or not --- I can feel your pain), and I know it's hard to see some types of errors when you keep looking at the same stuff for hours at a time.

It would be easier (at least it is for me) if you would use indentation and some kind of line spacing to make the code more readable

Next time you post code put code tags around it.

Code:

#include<stdio.h>
#include<conio.h>
void main()
{
  float eng, maths, de, it, c, avmar;

  printf("enter the marks for english: ");
  
  scanf("%f", &eng);
  printf("enter the marks for maths: ");

  scanf("%f", &maths);
  printf("enter the marks for digital electronics: ");
  
  scanf("%f", &de);
  printf("enter the marks for information technology: ");

  scanf("%f", &it);
  printf("enter the marks for c: ");

  scanf("%f", &c);
  avmar=(eng + maths + de + it + c) / 5;

  printf("the average marks are = %f", avmar);

  if((avmar < 39) && (avmar > 0))
    printf("fail");
  else if((avmar < 49) && (avmar > 40))
    printf("third division");
  else if((avmar < 59) && (avmar > 50))
    printf("second division");
  else if((avmar < 79) && (avmar > 60))
    printf("first division");
  else
    printf("honours");
  
  getch();
}

Note there are a couple of bugs that you might not uncover by testing, so I'll give you a hint there also:

Enter 50 for all of the grades and see how they are classified


Regards,

Dave