Questions

[Daveo]

#include <stdio.h>
#include <math.h>
#include <conio.h>

int number, result;
double square_number;

int
square(int number)
{
    while(number >= 0)
    {
        square_number = pow(2,number);
    }    
}

int
main(void)
{
    printf("Enter an integer:");
    scanf("%d", &number);
    printf("\nNumber entered is: %d\n", number);
    result = square(number);
    
    while(number >= 0);
    {
        if(number < result)
        {
            printf("%d is a number less than the square of itself.\n", number);
            printf("Please enter another integer:\n");
            scanf("%d", &number);
        }
        else
        {
            printf("%d is a number greater than the square of itself.\n", number);
            printf("Please enter another integer:");
            scanf("%d", &number);
        }
    }
    getch();
    return (0);                  
}

Im a newbie at this, so please bare with me. This question relates to the main function. I have the following:

printf("Enter an integer:");
scanf("%d", &number);
printf("\nNumber entered is: %d\n", number);

and in the if statement, i have two alternatives, which have the code similar to above:

printf("Please enter another integer:\n");
scanf("%d", &number);

From the two examples of code, which are the same actions - ie, entering a number, is this correct? Is there a simpler way, like a call function?

Also, I have a function named square. Does it matter where I put the code? Its before the main function.

[hk_mp5kpdw]

#include <stdio.h>
#include <math.h>
#include <conio.h>

int number, result;
double square_number;  // This is not needed

double
square(int number)
{
    // You need to return a value here... the while loop is unnecessary
    // and in fact is an endless loop for n >= 0.
    //while(number >= 0)
    //{
    //    square_number = pow(2,number);
    //}
    //Just return the result of the pow function
    return pow(2,number);
}

int
main(void)
{
    printf("Enter an integer:");
    scanf("%d", &number);
    printf("\nNumber entered is: %d\n", number);
    result = square(number);  // This function call should go within the while loop
    
    while(number >= 0);
    {
        result = square(number);
        if(number < result)
        {
            printf("%d is a number less than the square of itself.\n", number);
            
            // These two lines of code are duplicate in both parts of the if/else
            // when you only need to ask the user once
            printf("Please enter another integer:\n");
            scanf("%d", &number);
        }
        else
        {
            printf("%d is a number greater than the square of itself.\n", number);
            
            // Again, you don't need these two lines here
            printf("Please enter another integer:");
            scanf("%d", &number);
        }
        //Just have the code to ask user for another number in one place
        printf("Please enter another integer:");
        scanf("%d", &number);

    }
    getch();
    return (0);                  
}

Also, I have a function named square. Does it matter where I put the code? Its before the main function.

If you have the function defined as you do, before its actual use elsewhere in the code, then you don't need a function prototype. If however you define the function later in the code after you have made a call to it somewhere prior in the source then you will need to prototype it, i.e.

double square(int number);  // Need this prototype

int main()
    ...
    result = square(number);  // Function called before it is fully defined
    ...
}

double square(int number)  // Finally we define the function
{
    return pow(2,number);
}

[edit]number and result should probably be doubles[/edit]