Thread: swap funtion

ok here's the problem i have this swap function that was created for a previous program, and i want to use it for a sort routine (bubble)

struct students temp;

strcpy(temp.name, s1->name);
temp.test1 = s1->test1;
temp.test2 = s1->test2;


strcpy(s1->name, s2->name);
s1->test1 = s2->test1;
s1->test2 = s2->test2;


strcpy(s2->name, temp.name);
s2->test1 = temp.test1;
s2->test2 = temp.test2;
}

so the question is how do i go about passing elements of a structure(a string) from the sort funtion, into the swap fuction.

heres the bubble sort so far

void sort_make(struct cars *inven, int number){
int i, j;
for(j = number; j > number ; j--){

for(i = 0; i < j; i++){

if(inven[i].make > inven[i+1].make)
swap(&inven[i].make, &inven[i+1].make);
}
}

}

-ManicC-

thanks, so what's the syntax for passing from the bubble sort to the swap function? i just want to compare and sort a string element of a structure?

How about?

Code:

void swap(students *s1, students *s2)
{
   struct students temp;

   strcpy(temp.name, s1->name); 
   temp.test1 = s1->test1; 
   temp.test2 = s1->test2; 


   strcpy(s1->name, s2->name); 
   s1->test1 = s2->test1; 
   s1->test2 = s2->test2; 

   strcpy(s2->name, temp.name); 
   s2->test1 = temp.test1; 
   s2->test2 = temp.test2; 
}

ok the problem is with the bubble sort itself
this is what i have now

void sort_make(struct cars *inven, int number){
int i, j;
for(j = number; j > number ; j--){

for(i = 0; i < j; i++){

if(inven[i].make > inven[i+1].make)
swap(&inven[i].make, &inven[i+1].make);
}
}

}

the warning i get is incompatiable pointer type, also do i have to make a different swap file for each element i want to sort?

sure

struct cars{

char make[20];
char model[20];
char color[20];
int year;
int price;
}inven[50];


and

void swap(struct cars *s1, struct cars *s2);

i'm really not sure about the swap prototype

hmmmm...i'm really lost, i have no idea how to sort this info using a bubble sort heres the complete code if anyone has any ideas, please let me know


#include <stdio.h>

struct cars{

char make[20];
char model[20];
char color[20];
int year;
int price;
}inven[50];



int print_menu(void);
void sort_make(struct cars*inven, int);
void sort_model(struct cars*inven, int);
void sort_color(struct cars*inven, int);
void sort_year(struct cars*inven, int);
void sort_price(struct cars*inven, int);
void print_input(struct cars*inven, int);
void swap(struct cars *s1, struct cars *s2);



int main(void)
{

int i, number, choice;



printf("Enter the number of cars: ");
scanf("%d", &number);

for(i = 0; i < number; i++){
printf("--Car %d--\n", i + 1);
printf("Make: ");
scanf(" %s", &inven[i].make);
printf("Model: ");
scanf(" %s", &inven[i].model);
printf("Color: ");
scanf(" %s", &inven[i].color);
printf("Year: ");
scanf(" %d", &inven[i].year);
printf("Price: ");
scanf(" %d", &inven[i].price);
printf("\n");
}
print_menu();

if(choice == 1)
print_input(inven, number);
else if(choice == 2){
sort_make(inven, number);
}
else if(choice == 3){
sort_model(inven, number);
}
else if(choice == 4){
sort_color(inven, number);
}
else if(choice == 5){
sort_year(inven, number);
}
else if(choice == 6){
sort_price(inven, number);
}
else{
printf("error please make a selection");
}


}



int print_menu(void){
int choice;
printf("How would you like the list displayed?\n");
printf("1. Show list as input\n");
printf("2. Show sorted by make\n");
printf("3. Show sorted by model\n");
printf("4. Show sorted by color\n");
printf("5. Show sorted by year\n");
printf("6. Show sorted by price\n");
printf("Choice: ");
scanf("%d", &choice);
printf("\n");
return choice;
}


void print_input(struct cars *inven, int number){

int i;
printf("Make \tModel \tColor \tYear \tPrice\n");
printf("---- \t----- \t----- \t---- \t-----\n");

for(i = 0; i < number; i++){

printf("%s \t%s \t%s \t%d \t%d\n", inven[i].make, inven[i].model, inven[i].color, inven[i].year, inven[i].price);
}
}

void sort_make(struct cars *inven, int number){
int i, j;
for(j = number; j > number ; j--){

for(i = 0; i < j; i++){

if(inven[i].make > inven[i+1].make)
swap(&inven[i], &inven[i+1]);
}
}

}

void sort_model(struct cars *inven, number){
}

void sort_color(struct cars *inven, number){
}

void sort_year(struct cars *inven, number){
}

void sort_price(struct cars *inven, number){
}