copying file into string - not working?

[ccoder01]

hi,

im just simply copying the whole contents of a file from the net into a string in my program and printing it out...this doesnt work,,any suggestions on how to fix or do it another way?

FILE *p;
	char *file = NULL;
	long fileSize = 0;	
	
	if((p = popen("/usr/other/sdm/Bin/wget -q -O - http://homepages.ihug.com.au/~pooni/xml/test.xml","r")) == NULL) {
		
		fprintf(stderr, "cannot create pipe \n");
		exit(1);		
	}
  	
	fseek(p, 0, SEEK_END);
	fileSize = ftell(p);
	rewind(p);
	
	if (fileSize < 1){
		fprintf(stderr, "File has no data\n");
		exit(1);
	}
	
	file = (char *) calloc((fileSize+1), sizeof(char));
	
	if (!file){
		fprintf(stderr, "Unable to allocate %d bytes of memory\n", fileSize);
		exit(1);
	}

	fread(file, fileSize, 1, p);
	file[fileSize] = '\0';
	
	printf("File is %ld bytes. File Data:\n%s\n", fileSize, file);

	free(file);
	fclose(p);

[Salem]

I somehow doubt that you can seek/rewind a pipe
Try checking the status returns from those functions to see if they return an error

> or do it another way?
Like a linked list of lines for example.

[ccoder01]

is there any other way i can copy the contents of a file into a string..?

[Salem]

Same way as you handle a normal text file

char buff[BUFSIZ];
while ( fgets( buff, BUFSIZ, p ) != NULL ) {
  char *line = malloc ( strlen(buff) + 1 );
  if ( line ) {
    strcpy( line, buff );
    // append line to whatever expanding data structure you have
    // I suggested a linked list
  }
}