Thread: Command line args

First time using command line args in C, and can't get it to work. Here's what I got:

this should get the one and only command line argument, which is a filename, then it calls openFile with that. If there is no command line arguments, it gets it from within the program.

Code:

if(argc == 2){		
		if(openFile(argv[1]) == 1){
			countWords();
			showResults();
			closeFile();	
		}
		else{
			printf("Does not exist\n");
			return EXIT_FAILURE;
		}
	}
	else{
		getFileName();
		if(openFile(fileName) == 1){
			countWords();
			showResults();
			closeFile();	
		}
		else{
			printf("Does not exist\n");
			return EXIT_FAILURE;
		}
	}

and here is my open file

Code:

int openFile(char* filename){
	/*Open the file*/
	if((inFile = fopen(fileName, "r")) == NULL){
		return 0;
	}
	return 1;
}

The code for getting the filename within the program works fine, it just tells me the file does not exist whenever it gets run with the command line arg. Any suggestions?

thanks salem

This one works for me.

static FILE *open_file ( char *file, char *mode )
{
FILE *fp = fopen ( file, mode );

/* "r" open for reading */
/* "w" create for writing, discard previous contents */
/* "a" append, open or create for writing */
/* "r+" open for update */
/* "w+" create for update, discard previous contents */
/* "a+" append, open or create for update */

if ( fp == NULL ) {
printf("Unable to open %s for %s\n", file, mode);
perror ( "Unable to open file" );
exit ( EXIT_FAILURE );
}

return fp;
}