Thread: Not very proud of this Code.

I simply need to "write a program that reads input until encountering #. have the program print each input character and its ASCII decimal code. Print eight character code pairs per line"

I did the following code using the conio.h.

Code:

/* review #1.c */


#include <stdio.h>
#include <conio.h> /* for getche() */
#include <stdlib.h>

int main(void){

    char ch;
    int chrcnt = 0;

    printf("Type any text and I will display your ASCII value\n\n");
    while ( (ch = getche()) != '#'){  /* returns single charater automatically. meaning is not buffered
    not ainsi and not posix  - bad*/
          chrcnt++;
          printf(" = %d ", ch);
          if ( (chrcnt % 8 == 0)){
             printf("\n\n");
             }
          }


   printf("\n\nYou have %d characters.\n", chrcnt);

   getche();
   return (0);

}

However conio is not ANSI nor is it POSIX. And I would like to make it ANSI at least. I was wondering how you could rewrite the code without the conio.h.

A max of 8 characters per line must be outputed and there can be no use of pointers nor arrays. This is where I'm at in my studies. However I can not think of a way to use getchar() without incurring a newline. As far as I know getchar() is buffered right? meaning you need to press enter before it is displayed. However Pressing Enter will start a newline the opposite of my intent. How do I solve this please. What am I not looking at?Thank you, I don't know why it seems i've drawn a blank.

P.S. This is not homework. I'm self-taught and reading "The waite group's new C primer plus"

Never mind...

Read this

Basically there isn't a standards way to do this.

I thought getche (); would give me errors....

I didnt know it was part of conio and i change my earlier message.

What do you mean by echo?
Coz getch doesnt work on my compiler..

getche() is usally defined as follows:

Code:

{
  char ch;
  ch = getch();
  putchar(ch);
  return ch;
}

getch() captures the character but doesn't display it. And I might be wrong on ch being char, it might be int. Its been a little bit since I looked at it.

So i wont be able to use the value i get from getch but i can use the value i get from getche...or is it just my compiler...

if your compiler doesn't have getch() it won't have getche().

Originally posted by Thantos
Read this

Basicall2)y there isn't a standards way to do this.

1)I see. Thanks for the links. I'm assuming there must be a way as my book is giving me this as an example. There must be something collectively we are not thinking of?

2)>>Just use fgets() to read the input into a buffer then look at each character in the buffer.

Can't use that now, as I have not covered it yet. Also using getchar. It would echo my input and in order to output the ASCII value i would need to press enter. This would not conform to the task at hand. Meaning output eight characters and their ascii value on one line.

3)>>Read this.
I read it and even compiled the code using getch(), however when I inputed my password, i failed to recieve a '*' in place of the char. what gives?

4)>>"I thought getche (); would give me errors....I didnt know it was part of conio and i change my earlier message.
What do you mean by echo?
Coz getch doesnt work on my compiler.."

you might want to take a look


here for some ANISI and POSIX functions nomi, It gives some explanations along with a table of contents.


In regards to my question. Is there nothing anyone can think of right now?

This would not conform to the task at hand. Meaning output eight characters and their ascii value on one line.

What about \b?

getch() and getche() are compiler specific. If this is for a class then most likely the compiler they are using has those functions.

There are no perscribed compilers that the book recommends. It's actually conforming to ANSI C

It's actually conforming to ANSI C

If it uses getch() then it isn't conforming 100% to ANSI C. Every book I've read has stated that they will be making an assumption on the compiler.