Thread: Database v.2.2

More updates on my database pulling it upto v.2.2 because of:
http://cboard.cprogramming.com/showt...threadid=49407

Once again....plz mark my work:
1. Program Efficiency- /10
2. Documentation- /10
3. Programming Style- /10
4. User Interface- /10

I am attaching a *.zip file with the following contents:
database.cpp
database.exe
WMinventory.dat
WMinventory.dat.cpy

Thanks for the help...and I will keep making changes until you guys can find mistakes. Plus, try crashing my program by enterint character instead of integars, etc...and tell me where my programme falls apart.

Thx,
nomi

changed:

Code:

    scanf("%d",&userChoice);
    while(getchar() != '\n');

To:

Code:

    ch = getche();
    userChoice = ch - '0';

Making more changes....plz help me in this process.

LAtest Files.

Code:

fgets(test,MAXchar,stdin);
test[strlen(test)-1]='\0';

Possible problem if the user enters MAXchar characters. a modified version is this:

Code:

fgets(test,MAXchar,stdin);
if ( test[strlen(test)-1]=='\n')
  test[strlen(test)-1]='\0';

Also I like to use sizeof() for the size that way I never have to worry about changing the size of the array without changing the function. Since you are using a define it is less of a problem but I believe its a little better to use sizeof().

Code:

clrscr();

This is often unneeded and destructive.

Might look into using a switch/case instead of else if. I find it easier to read.

WaltP suggested that, but i didnt know how to implement it...

Thanks.

switch case works like this:

Code:

switch ( variable that can be used as an integer )
{
  case #1: blah; blah; blah;break;
  case #2: blah; blah; blah;break;
  ...
  default: blah; blah; blah;break;
}

in your case:

Code:

    do{
        choice = mainMenu();   
        Stemplate();        
        switch ( choice )
        {
          case 1:
            do{
                loop = addItems(inventory,&arrayL);
              }while (loop);
            break;
          case 2:
            do{
                loop = deleteItems(inventory,&arrayL);
              }while (loop);
            break;

          case 3:  viewItems(inventory,arrayL); break;
          case 4:  sortItems(inventory,arrayL); break;
          case 5:  searchItems(inventory,arrayL);
          case 0:  exitScreen(); break;
          default:  puts("Invalid input");
        }
 
    saveData(inventory,arrayL);
    }while(choice != 0);

Lolz...i was talking about the fgets();

THx a lot though.

CAn you rate my programme too?