Error when running a simple program

[swishiat.com]

hi all,
this a simple program in FILES, the program read 3 data and saved in FILE and call the function print to print the FILE

#include<stdio.h>
/*********** Data ***********/
typedef struct {
	int id;
	float gpa;
}data;
/*********** The functions ***********/
void read(data*);
void print(FILE*);
/*********** Main ***********/
int main(){
	data R;
	FILE *f1;
	int i;
	if((f1=fopen("f1.dat","w"))==NULL)
		printf("sorry i can not open the file\n");
	else{
	for(i=0;i<3;i++){
		read(&R);
		fprintf(f1,"%d %.2f",R.id,R.gpa);
	}
	fclose(f1);
	print(f1);
	}
	return 0;
}
/*********** Read ***********/
void read(data *R){
	printf("Enter the id :");
	scanf("%d",&R->id);
	printf("\n");
	printf("Enter the gpa :");
	scanf("%f",&R->gpa);
	printf("\n");
}
/*********** Print ***********/
void print(FILE *f){
	data R;
		if((f=fopen("f.dat","r"))==NULL)
		printf("sorry i can not open the file\n");
	else{
	while(!feof(f)){
		fscanf(f,"%d %.2f",&R.id,&R.gpa);
		printf("The id is: %d the gpa is: %.2f",R.id,R.gpa);
	}
	fclose(f);
}
}
/*********** End ***********/

the out is
Enter the id :1

Enter the gpa :2.9

Enter the id :2

Enter the gpa :3.8

Enter the id :3

Enter the gpa :4.5

sorry i can not open the fil //why can not open??????
Press any key to continue

[Thantos]

fopen("f1.dat","w")

vs

fopen("f.dat","r")

[swishiat.com]

i dont understand???
can u explain to me pleas and put the program after chang

[Thantos]

Sorry I don't speak nitwit so I can't simply it any more then this:
You are opening the file "f1.dat" to write the information and then trying to read the said information from file "f.dat".

edit: Just so you understand, the explaintion wasn't in nitwit, it was the level right above nitwit.

[swishiat.com]

Its a shame having people like you in such a great board
Simply, if you are not interested in helping beginners its better to read only. And I'm sorry I wasted you time.
-------------------------------------------
Can anybody else help me??
its very important!!

[anonytmouse]

Well it can not open "f.dat" in your print() function because that file does not exist.

If you want to read the information that has been written you can open "f1.dat" as that is where you wrote it.

If you want to read some other information you have to make sure the file exists.

void print(FILE *f){
	data R;
		if((f=fopen("f.dat","r"))==NULL)
		printf("sorry i can not open the file\n");
	else{
	while(!feof(f)){
		fscanf(f,"%d %.2f",&R.id,&R.gpa);
		printf("The id is: %d the gpa is: %.2f",R.id,R.gpa);
	}
	fclose(f);
}

As you are not using the value of f you probably want to change this function so it takes no arguments.

void print(void){
	data R;
	FILE * f;

	/* Do you really want to open "f1.dat" here? */
	if((f=fopen("f.dat","r"))==NULL)
		printf("sorry i can not open the file\n");
	else{
		while(!feof(f)){
			fscanf(f,"%d %.2f",&R.id,&R.gpa);
			printf("The id is: %d the gpa is: %.2f",R.id,R.gpa);
		}
		fclose(f);
	}
}

Have Fun!

[Thantos]

Jesus $$$$ing Christ. I pointed out the problem with your code and then even explained it to you. Its YOUR job to take the feedback and try to absorb it. You had a very simple mistake which was pointed out.

Do ask questions. But don't expect us to rewrite the program. Look at how I ask questions. I give an explantion of the problem I'm encountering, what I'm trying to do, and then the code. When someone responds, I take what they give me and figure out if that solves the problems, if so how, and if not I'll respond with that and usally ask another question.

If you can't take two feakin seconds to do a search in your code for what I put up then its not my problem.

And yes I'm in a bad mood today.

[swishiat.com]

anonytmouse
Thank you very much for your help, but still there is a littel proplem when i run the program
i write
------------------
id 1 , gpa 2.3
id 2, gpa 3.6
id 3,gpa 4.7
in out is
Enter the id :1

Enter the gpa :2.3

Enter the id :2

Enter the gpa :3.6

Enter the id :3

Enter the gpa :4.7

The id is: 1 the gpa is: 2.30
The id is: 3 the gpa is: 0.60
The id is: 4 the gpa is: 0.70
Press any key to continue
------
and now I'm working on it

[swishiat.com]

Thantos
I've gotten your point
ðWe are all here to share our opinions
I'm sorry if I bothered you

[Thantos]

Sorry, was a little over the top.

[swishiat.com]

what is worng now????????????
no error when i run the program but it is give me double the last one
the out put is
Enter the id :1

Enter the gpa :1.2

Enter the id :2

Enter the gpa :2.6

Enter the id :3

Enter the gpa :3.8

The id is: 1 the gpa is: 1.20
The id is: 2 the gpa is: 2.60
The id is: 3 the gpa is: 3.80
The id is: 3 the gpa is: 3.80 ///// why print again?????
Press any key to continue
----
the code

#include<stdio.h>
/*********** Data ***********/
typedef struct {
	int id;
	float gpa;
}data;
/*********** The functions ***********/
void read(data*);
void print(FILE*);
/*********** Main ***********/
int main(){
	data R;
	FILE *f;
	int i;
	if((f=fopen("f.dat","w"))==NULL)
		printf("sorry i can not open the file\n");
	else{
	for(i=0;i<3;i++){
		read(&R);
		fprintf(f,"%d %.2f ",R.id,R.gpa);
	}
	fclose(f);

		if((f=fopen("f.dat","r"))==NULL)
		printf("sorry i can not open the file\n");
	else{
	while(!feof(f)){
		fscanf(f,"%d %f",&R.id,&R.gpa);
		printf("The id is: %d the gpa is: %.2f\n",R.id,R.gpa);
	}
	fclose(f);
}
	}
	return 0;
}
/*********** Read ***********/
void read(data *R){
	printf("Enter the id :");
	scanf("%d",&R->id);
	printf("\n");
	printf("Enter the gpa :");
	scanf("%f",&R->gpa);
	printf("\n");
}
/*********** Print ***********/
void print(FILE *f1){
	data R;
 	if((f1=fopen("f1.dat","r"))==NULL)
		printf("sorry i can not open the file\n");
	else{
		fscanf(f1,"%d %f",&R.id,&R.gpa);
	while(!feof(f1)){
		printf("The id is: %d the gpa is: %.2f\n",R.id,R.gpa);
		fscanf(f1,"%d %f ",&R.id,&R.gpa);
	}
	fclose(f1);
}
}
/*********** End ***********/

[hairyian]

feof() doesn't do what you think it does... or in fact, what anonytmous thinks it does.

feof() only tells you EOF has occured only when some other stdio function (fscanf in your case) has already reported it. So any code of the form:

while (!feof()) {
  int foo;
  fscanf("%d",&foo);
  printf("%d\n",foo);
}

doesn't do what you think it does. It should be written:

int status;
do {
  int foo;
  

  status=fscanf("%d",&foo);
  if (status==1) {
    printf("%d\n",foo);
  } else if (status!=EOF) {
    /* fscanf failed didn't EOF, but failed to match all the input.
        The inputted data is corrupted in some way. */
  }
} while (status!=EOF);

with not an feof() in sight. Generally, there's no need whatsoever to call feof().

Your mistake is not checking the return values of all your fscanf calls. Take a look in your C reference material for what fscanf returns under what circumstances.

Ian Woods