CALLOC / 2-D Array Creation

[wbeasl]

I have an assignment to create a two dimensional array based on user inputs. A prompt is done for the size of the row and column and then a 2-D array is to be created based on the inputed dimensions. The attached code compiles okay but crashes if the row and column are not the same size. For example, if I input row = 10, col= 10 then everything is okay but if I input row = 5, col = 6, then the program crashes.

Suggestions?

[code]
#include <stdio.h>
#include <stdlib.h>
#include <time.h> /* Required for random integer */
#include <windows.h> /* Required for clearScreen function */

int main (void) {

short int outer;
short int inner;
short int rowInput;
short int colInput;
short int size;
short int *row;
short int *col;

int **arrayx;

printf("Enter the row: ");
scanf("%d", &rowInput);

printf("\nEnter the col: ");
scanf("%d", &colInput);

row = &rowInput;
col = &colInput;

size = *row * *col;

printf("\n\nSize is %d", size);
printf("\n\n");

arrayx = (int **)calloc (*row, sizeof(int*));
arrayx [*col] = (int *)calloc (*col, sizeof(int));

for (outer=0; outer < *row; outer++) {
for (inner=0; inner < *col; inner++)
arrayx [*row] [*col] = 10;
/* crashes when row <> col */

/* (*(*arrayx + outer) + inner) = 1;
above statement does not work but
the one before it does seem to
compile okay */

} /* end for outer < row */

return 0;

} /* end function main */
[code]

[Prelude]

>Suggestions?
Find the differences?

#include <stdio.h>
#include <stdlib.h>

int main ( void )
{
  int i, j;
  int row, col;
  int **array;

  printf ( "Enter dimensions (row,col): " );
  fflush ( stdout );
  if ( scanf ( "%d%*c%d", &row, &col ) != 2 ) {
    fprintf ( stderr, "Some kind of input problem\n" );
    return EXIT_FAILURE;
  }
  /*
   * No error checking, it hides the logic
   */
  array = calloc ( row, sizeof *array );
  for ( i = 0; i < row; i++ )
    array[i] = calloc ( col, sizeof *array[i] );
  for ( i = 0; i < row; i++ ) {
    for ( j = 0; j < col; j++ )
      array[i][j] = i * j;
  }
  for ( i = 0; i < row; i++ ) {
    for ( j = 0; j < col; j++ )
      printf ( "%-5d", array[i][j] );
    printf ( "\n" );
  }
  for ( i = 0; i < row; i++ )
    free ( array[i] );
  free ( array );

  return EXIT_SUCCESS;
}

[quzah]

Look to the left to see how code tags work.
<---

Beyond that, why are you complicating this by using the pointers 'row' and 'col' when you have already read into integers which hold this information for you?

[edit]Prelude beat me to the rest of the answer.[/edit]

Quzah.

[Salem]

All was wonderful for a while, the new system for detecting code and prompting posters was working well for a while

But it seems the noobs have evolved into even more creative ways of making their posts illegible.

[Prelude]

>But it seems the noobs have evolved into even more creative ways of making their posts illegible.
Artifical solutions have no effect against natural fools.