Thread: # of ones in Binary representation

Can someone tell me why my program does not compile?


__________________________________________________ _

int bitcnt ( float n );

#include<stdio.h>

int main ( void )
{
float n;

for (;
{
printf("Give a positive integer ( <=0 to stop ) : ");
scanf("%f", &n);
if (n <= 0) break;
printf("Number of ones in bit representation of %f : %.2f\n",
n, bitcnt(n));
}

return 0;
}
int bitcnt ( float n )
{
int cnt = 0;
float work;

for (work = n; work > 0; work /= 2)
cnt += (work % 2);

return cnt;
}

why are you floating n if you want them to enter an integer?

Ok, I changed floats to int.....and its works correctly.


int bitcnt ( int n );

#include<stdio.h>

int main ( void )
{
int n;

for (;
{
printf("Give a positive integer ( <=0 to stop ) : ");
scanf("%d", &n);
if (n <= 0) break;
printf("Number of ones in bit representation of %d : %d\n",
n, bitcnt(n));
}
return 0;
}

int bitcnt ( int n )
{
int cnt = 0;
int work;

for (work = n; work > 0; work /= 2)
cnt += (work % 2);

return cnt;
}
------------------------------------------------------------------------------------
Thanks for the hint.

This is just a general, non-all-purpose bit counter:


int BitterGitter(int);


int BitterGitter(int num)
{
int bits = 0;
int i;

while(i<16)
{
bits += (0x0001 & num);
num >>= 1;

i++;
};

return(bits);
}


enjoy.