Thread: C newbie with weird problem

I am writing a c program to recursivly search a path for .tff files and coutn them (Windows 2k). I have a program that does that correctly, but when I try to print out the count I get a weird result. here's the code

Code:

#include <windows.h>
#include <stdio.h>
#include <dir.h>
#include <string.h>

#define DELIM	"."

void searchDir(char *);
int endsWith(char *, char *);

int scanC = 0;


int main(void){
	searchDir("c:\\users\\clipper\\scan");
	printf("%d files found\n", scanC);

	exit(0);

}

void searchDir(char *path){
	WIN32_FIND_DATA FileData;
	HANDLE hSearch;
	DWORD dwAttrs;
	BOOL fFinished = FALSE;
	char * temp;

	chdir(path);
	hSearch = FindFirstFile("*.*", &FileData);
	if (hSearch == INVALID_HANDLE_VALUE)
	{
	    return;
	}


	while (!fFinished)
	{

		dwAttrs = GetFileAttributes(FileData.cFileName);

		if(dwAttrs & FILE_ATTRIBUTE_DIRECTORY){
			if(strcmp(FileData.cFileName, ".")!=0 && strcmp(FileData.cFileName, "..")!=0){
				temp = lstrcat(path, "\\");
				temp = lstrcat(temp, FileData.cFileName);
				searchDir(temp);
			}
		}

		if(endsWith(FileData.cFileName, "tiff") == 0){scanC++;}


	    if (!FindNextFile(hSearch, &FileData))
	    {
	        if (GetLastError() == ERROR_NO_MORE_FILES)
	        {
	            fFinished = TRUE;
	        }
	        else
	        {
	            printf("Couldn't find next file.");
	            return;
	        }
	    }
	}

	// Close the search handle.

	FindClose(hSearch);
	return;
}

int endsWith(char *str1, char *str2){
	char *token;
	char strcpy[MAX_PATH];

	lstrcpy(strcpy, str1);

	token = strtok(strcpy, DELIM);
	token = strtok(NULL, DELIM);
	if(token != NULL)return strcmp(token, str2);
	else return 1;
}

the 'printf("%d files found\n", scanC);" in main outputs the last file run through endsWith() (so I think) anyway it spits out a file name (with its path) whats up with that?

Two points: you use strcpy as the name of a variable in
endwith(). strcpy is defined in the C runtime as an entry
point for a string copy routine (in string.h which you
include). Your code probably is whacked out by doing that.

Second, try this instead of the endswith routine and see if
it doesn't do what you want:

Code:

if(strstr(FileData.cFileName, ".tiff")!=NULL) scanC++;

Okay, your code worked to replace the endsWith() function, but it didn't solve my problem. Code there be some buffer problem in the code? I pulled some of it from MSDN and got other tidbits from books and this site.

Don't use strcpy as a variable name. You're corrupting memory.

I have taken the function endsWith() completely now, thanks for the code peice it worked great. I have thrown a few more debug statements in the code and now I see the problem a bit more clearly:

When main looks like:

Code:

int main(void){
	searchDir("c:\\users\\clipper\\scan");
	exit(0);

}

The program recusivley finds all the tiffs corectly. but when I add to main

Code:

int main(void){
	searchDir("c:\\users\\clipper\\scan");
	printf("%d files found\n", scanC);
	exit(0);

}

the directory is searched twice and I find twice as many .tiff's!!

I got the counter working. For some reason the call

Code:

if(dwAttrs & FILE_ATTRIBUTE_DIRECTORY)

always is true. I found a way around the problem though. Thanks for all the help.

here's the code:

Code:

#include <windows.h>
#include <stdio.h>
#include <dir.h>
#include <string.h>

#define BUFSIZE 1024

void searchDir(char *);
int endsWith(char *, char *);

int scanC = 0;


int main(void){
    LPTSTR user;      // pointer to system information string
    DWORD cchBuff = BUFSIZE;    // size of computer or user name
    TCHAR tchBuffer[BUFSIZE];   // buffer for string

	GetUserName(user, &cchBuff);

	searchDir("e:\\users\\clipper\\scan"); //start inital search

	printf("%d files found for %s\n", scanC, user);
    system("pause");
	return;

}

void searchDir(char *path){
	WIN32_FIND_DATA FileData;
	HANDLE hSearch;
	int check;
	BOOL fFinished = FALSE;
	char temp[MAX_PATH];

	//first I move to the directory specified by "path"
	check = chdir(path);
	if(check != 0)return;  //if chdir() fails I'm not searching a directory therefore I return

	//get directory listing
	hSearch = FindFirstFile("*.*", &FileData);
	if (hSearch == INVALID_HANDLE_VALUE)
	{
	    return;
	}


	while (!fFinished)
	{

		if(strcmp(FileData.cFileName, ".")!=0 && strcmp(FileData.cFileName, "..")!=0){
				//search on each listing in the directory
				sprintf( temp, "%s\\%s", path, FileData.cFileName);
				searchDir(temp);
		}

		if(strstr(FileData.cFileName, ".tiff")!=NULL)scanC++;



	    if (!FindNextFile(hSearch, &FileData))
	    {
	        if (GetLastError() == ERROR_NO_MORE_FILES)
	        {
	            fFinished = TRUE;
	        }
	        else
	        {
	            printf("Couldn't find next file.");
	            return;
	        }
	    }
	}

	// Close the search handle.

	FindClose(hSearch);
	return;
}