whats wrong of this program

[maniel]

#include <stdio.h>
int main()
{
        int i;
        char input[80];
        printf("Enter a string please:");
        gets(input);

        printf("The words are:\n");
        for(i=0; input[i]<=80; i++)
        if(input[i]!=' ')
        printf("%c", input);
        else if(input[i]==' ')
        printf("\n");

return 0;
}

the program breaks the string into parts
but there is a problem, it stop in the for loop and print nothing....
how can i solve this problem??

[Thantos]

        for(i=0; input[i]<=80; i++)
            {
            if(input[i]!=' ')
                 printf("%c", input);
            else if( input[i]==' ' )
               printf("\n");
            }

Your else statment was not inside the for loop.

[XSquared]

And you can just use else, too. You don't need the 'if( input[ i ] == ' ' )' part.

[MrWizard]

You'd better hope no one else sees this. Switch to fgets for the string input. It's a better function because you specify how many bytes you want to read in therefore avoiding problems like buffer overflow. Also in your for loop you have the condition as being <= 80. Well your array is 80 elements [0-79] so you don't actually have an 80 index. Change it to a < and that should be good. Also try putting braces around your for loop to include the if and else. Good job with the code tags and using int main though.

Edit:

Actually your condition for your for loop is "input[i] <= 80" why are you checking the array? just use "i < 80"

[maniel]

thx.but can i base on this stupid program to have a 2d array and break the string into words?

[Draco]

The strtok() function will make breaking up the words an easy job for you. This url will take you to the faq page that explains exactly what you want to do.

http://faq.cprogramming.com/cgi-bin/...&id=1044780608

[maniel]

thx!but can i do it in another way.
i have tried one like this

#define maxsize 80
#include <stdio.h>
int main()
{
        int i;
        char input[maxsize];
        char real[maxsize][maxsize];
        printf("Enter a string please:");
        gets(input);

        printf("The words are:\n");
        for(i=0; input[i]!='\0'; i++)
        {
        if(input[i]!=' ')
        real[i][i]=input[i];
        printf("%s\n", real);
        else
        printf("\n");
        }
return 0;
}

but the output is that the program can only print the first character(if i enter hi hi, it prints h only)
how can the program print
hi
hi
??

[addisonp]

if(input[i]!=' ')
        real[i][i]=input[i];
        printf("%s\n", real);
        else
        printf("\n");

your if statement only is doing the first command, while the printf will go all the time and the else isn't attached to the if statement.


Btw add tabs to your code so you can catch this problem

              
  currently written as:
     if(input[i]!=' ')                        
            real[][]                                    
     printf                                                
     else                                      
            printf                         

should be:
     if(input){
             real[]
             printf
      }
      else

Use curly brackets for all the statements your if and else are using to make the code more readable


-Addy