Thread: First program

To compare strings, you must use the strcmp() function, you cannot use ==.

Code:

if (!strcmp(c, kate))
{
...
}

>>>scanf("%c",c);

This needs to be scanf("%s", c);
notice the %s to input a whole string and not just 1 character.

----edit---- It would be best also to make sure the compiler knows main returns int by saying

Code:

int main()

>>>As well I'm not sure what header strcmp() is in on your compiler. For Borland and DJGPP it is usually in <string.h> but I'm sure MSVC is different.

That is the C standard string library. MSVC, Borland, GCC, and almost all compilers use that header for string manipulation.

If you don't want to use strcmp you could also compare your strings element by element but that's no smoth way of doing it imho.

:edited for spelling mistakes:

Originally posted by Elite
Hi, I'm new here. I've been trying to make this program work but i'm not sure how to store text user input. This program seems to miss the first statement no matter what the input. Sorry for being such a noob

Code:

#include <stdio.h>

char c[6];
char kate[7] = "kate";

main()
{
	printf("What is your name : ");	
	scanf("%c",c);
	if(c == kate) printf("Thats a great name");
	else printf("What a $$$$ name");
return 0;
}

Code:

#include <stdio.h>
#include <string.h>

int main(void)
{
      char ustr[30], cstr[] = "Kate", *p;
      
      printf("What is your name: ");
      fgets(ustr, sizeof(ustr), stdin);

      if((p = strchr(ustr, '\n') != NULL)
           *p = '\0'; /* strip newline if present */

      if(strcmp(ustr, cstr) == 0)
            printf("%s, that's a great name!", ustr);
      else
            printf("%s, isn't a bad name either", ustr);      

      return 0;
}

If you want not to worry about case in the user entry such as "kate" being the same as "Kate", "KaTe", or "KATE", then use stricmp

Code:

if((p = strchr(ustr, '\n')) != NULL)

>then use stricmp
Note that stricmp is non-standard and may not be available.

And it is best to have a newline presented to the stdout before a program exits, otherwise it may not be displayed.