Help with handling strings

I'm writing a program that will send mail through an smtp server. I can send the commands fine by themselves but when I try to send them with user input (like asking for the desintation addr instead of hard coding it) I have problems.

I want the output to look like
MAIL From:<[email protected]>
RCPT TO:<[email protected]>

Here is my output and below is the relevant code, if anyone could help it would be much appreciated. Thanks

Output

Code:

---

[mr54561@taz3 networking]$ ./usermail [email protected]
(From) :[email protected]
RCPT To:<[email protected]@lkj.com>

Next is..
@[email protected]>

---

Code:

---

#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <strings.h>

#define SIZE sizeof (struct sockaddr_in)

main ( int argc, char *argv[]  )
{
  int sockfd, i;

char *fromer;
char helo[] = "HELO \n";
char kara[] = "MAIL From:<\n";
char to[] = "RCPT To:<";
char return_val[1024];
char input[1024];
  char c, rc;
  struct sockaddr_in server;

if (argc!=2 || argc>2){
printf("Correct syntax is 'usermail <recipient>'\n");
exit(1);
}

strcat(to,argv[1]);
strcat(to,">\n");



printf("(From) :");
gets(fromer);

strcat(kara,fromer);
strcat(kara,">\n");

printf("%s\n",to);
printf("Next is..\n");
printf("%s\n",kara);

---

Quote:

---

Originally posted by Salem
char *fromer;
gets(fromer);
Both these are wrong - fromer isn't pointing to any memory (or rather, a random area of memory), and you're using gets()
See the FAQ on why this is dangerous, and how to fix it.

---

Awww, you mean gets would be a bad thing in a CGI or mailto form? :D

Quzah.

Quote:

---

Originally posted by Salem
char to[] = "RCPT To:<";
...
strcat(to,argv[1]);
strcat(to,">\n");

C only allocates enough space in your array for the initial string - if you want to append data to it later on, then you must allocate space accordingly

char to[100] = "RCPT To:<";
....
strcat(to,argv[1]);
strcat(to,">\n");

---

Salem, you just made my day a whole lot brighter. Thank you very much.


Mike