Thread: problem with File

Hi,

its not a good idea to loop while testing if file opens okay, as the file would be opened as new every loop.

also your employee number is out of range to be stored as an int, you can either read this as a string, not a bad idea as the emp num is permanent and is not required in any calculations. Either that you will have to store employee number as a double.

unless you format your fscanf for len of string, then the first %s will read rest of file until a null char is encountered e.g. it will read the space characters between first and surnames.

Is each employee record seperated by a newline character, you will have to determin how each record on the file is seperated, if at all. Would be better to read file character at a time, checking for EOF and space between fields.

This should suffice for simple use

Code:

while ( fscanf(fp,"%d %s %s",&no, fname, lname) != EOF ) {
    add(no,fname,lname);
    printf("values added......");
}

But this is better

Code:

char buff[BUFSIZ];  // BUFSIZ in stdio.h
while ( fgets( buff, BUFSIZ, fp ) != NULL ) {
    if ( sscanf( buff, "%d %s %s", &no, fname, lname) == 3 ) {
        add(no,fname,lname);
        printf("values added......");
    } else {
        // invalid line format error
    }
}

> then the first %s will read rest of file until a null char is encountered e.g. it will read the space characters between first and surnames.
This is incorrect - %s stops at the first white space (or newline)