pointer w/o a cast.

**chrismiceli** · 03-26-2003

what I am trying to do is make a program where if the first argument is equal to a randomly generated "password", it will printf that you got through, I keep getting strcmp arg 2 makes pointer without a cast error. Here is the code

Code:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

int main(int argc, char *argv[]) {
	char pass[20], *pas;
	int ranmb, len, x;
	char range[] = "abcdefghijklmnopqrstuvwxyz1234567890", *rang;
	char lenrange[] = { 1, 2, 3, 4, 5 }, *lenrang;
	pas = pass;
	lenrang = lenrange;
	rang = range;
	if(argc!=2) {
		printf("Enter the password as an argument to enter, \n");
		printf("It is also case sensitive.\n");
		exit(0);
	}
	srand((unsigned)time(NULL));
	ranmb=rand()%37;
	len=rand()%6;
	for(x=0;x<*(lenrang+len);x++) {
		*pas=*(rang+ranmb);
		ranmb=rand()%37;
	}
	if(strcmp(argv[1],*pas)==0) {
		printf("You got through!");
		exit(0);
	}
	else {
		printf("Enter the password as an argument to enter, \n");
		printf("It is also case sensitive.\n");
		exit(0);
	}
}

**no-one** · 03-26-2003

you have to cast, put (char*) in front of both arguments of strcmp.

and include string.h for strcmp.

**quzah** · 03-26-2003

Originally posted by no-one
you have to cast, put (char*) in front of both arguments of strcmp.

and include string.h for strcmp.

No. You're wrong. The real problem is the fact that they're dereferencing a pointer:

char pass[20], *pas;
....
f(strcmp(argv[1],*pas)==0) {

Don't dereference it. Remove the * from the function call.

Quzah.

**Hammer** · 03-26-2003

You also forgot to #include <string.h>

One of the loops ain't too clever, particularly where it does this:
*pas=*(rang+ranmb);

You only ever update *pas, which is the first character in the array. So you never make the string longer than one character, and you also never terminate it with a \0.

What's the point of the lenrange array, when it's just filled with 1 - 5 ? It seems like this is an overkill:
*(lenrang+len)

This is a simple example that prints 5 random characters from the array:

Code:

#include <stdio.h>
#include <stdlib.h>

#define ASIZE(a) (sizeof(a)/sizeof(a[0]))

int main(void) 
{
  char range[] = "abcdefghijklmnopqrstuvwxyz1234567890";
  char buf[BUFSIZ];
  int i, num;
  
  for (i = 0; i < 5; i++)
  {
    num = rand() % (ASIZE(range) - 1);
    buf[i] = range[num];
  }
  
  buf[i] = '\0';
  puts (buf);    	
	
  return 0;
}

Thread: pointer w/o a cast.

Thread Tools

Search Thread

Display

pointer w/o a cast.

Similar Threads

test void pointer before cast (instanceof)

Pointer from a cast warning

Including The Right DLLs

How to fix misaligned assignment statements in the source code?

how to cast a char *mystring to a structure pointer ??