Thread: Too easy?

I'm sure this will be too easy and I'll feel like a stupid fool after a few posts But I'm getting a wee bit ........ed off with myself.
I want to open a file then check to see if the file name is correct and open it. The code compiles ok but always tells me that it can't open the file

Code:

FILE * fptrHistoryFile;  //Declares a global file pointer

 
 void main()
{
char HistoryFile[50], rightFile, n, y;
char * pHistoryFileLabel;
	
	
        do{
	

	puts("Please enter the name of the file that is to be checked e.g History.txt \n");
       	gets(HistoryFile);                 
	pHistoryFileLabel = HistoryFile;  //Assigns a poiter to the file name to be opened.
	
	printf("%s will now be checked. Is this right? \n", pHistoryFileLabel);
	puts("enter 'y' to continue or 'n' to input target file again \n");
	rightFile = getchar();    //Checks the file name is right.
	
        }while( rightFile == n );
        
        
        fptrHistoryFile = fopen("pHistoryFileLabel", "r");
       	if( fptrHistoryFile == 0)
	{
		puts("An error occured when opening the file ");
		exit(1);          //Checks the file is valid if not exits the program
	}
        
        
              
        
        


}

If anyone could throw some advice or suggest something to try i would be VERY grateful Please.
Thanks

Capulet

I'll suggest you one more thing, instead using gets(), you should try to use fgets().

Search a little bit about fgets().

Code:

fopen("pHistoryFileLabel", "r");

Hmm, "pHistoryFileLable"?
maybe without the " ".

Good luck.

Cheers for the quick reply and the advice.
But I still can't get the file to open succesfully might I be typing in the wrong file location? Do you have to pass the full location of the file e.g

I:\Projects\C Programming\Project_2002\History.txt

or is it just History.txt
Sorry to keep annoying you but it's really getting to me.
Thanks

Capulet

History.txt wont work, instead you make some changes.
Anyway, try passing the full path to the file, like:

Code:

C:\Programming\Cpp\History\History.txt

If it still don't work, tell use how did you write the path, and we'll see what's the error

but I did try c:\file.txt
and it did work well, anyway, you're right

Cheers for all of your advice
But I STILL get the message that I can't open the file. Is my code ok?
I keep the file I want to open at

I:\Project\history_1.txt

I've tried all of the ways that have been suggested but it still dishes out the same ****e back to me
Thanks for all of your help anyway you guys are the best



Capulet

You did try to open the file, like this, or not?

Code:

I:\\Project\\history_1.txt

Yeah I tried opening it that way with no joy.
I put the file in the same folder as the .exe and changed the files name from history_1.txt to history.txt and now it works fine

I can type in history.txt without typing in the full location and it works just fine.

Thanks very much for all of you guys help I will try to keep in mind what you have told me in future.
Cheers


Capulet

I really am a nob!!!

I thought my program was sorted but, no!
I've made the changes that Hammer suggested but it still won't open the file! Might it be my compiler? " Miracle C" I got it here
It was free but is it that which is causing me problems? I know I should get a good one but I've just started C ( you can probably tell? ) so I've not bought one yet.
Any help is really appreciated
Thankyou all


Capulet

Ok I'm going to get a new compiler now! and see if that sorts it out.
I think I'll try the Bloodshed Dev-C++ it sounds like it does the job well enough. I've had too many problems with "miracle" C
Thanks again for your help I'd go mad without it


Capulet

If this was in dos or a console window, then it might have been the 8.3 file format. For example, a file named

history_1.txt can be opened for reading or writing as history~1.txt provided the file already exists.