Thread: filling a deck of cards

ok so i want to write a function that fills a deck of cards and then print out the face values and their number or symbol:

Code:

#include <stdio.h>
#include <time.h>


char faces[]={"0023456789TJQKA"};

typedef enum
{
	eHearts=3,
	eDiamonds,
	eClubs,
	eSpades
}Cardsuit;

typedef struct
{
	char faceValue;
	Cardsuit suitValue;
}Card;

void filldeck(Card *);

main()
{	
	char i;
	Card Deck[52];
	Card *deckptr;
	deckptr=Deck;

	filldeck(deckptr);

	for(i=0;i<52;i++)
	{
		printf("%c--%c\n",faces[deckptr->faceValue],deckptr->suitValue);
		
	}

}

void filldeck(Card *deckptr)
{
	char i;
	char j;
	for(i=3;i<7;i++)
	{
		for(j=2;j<15;j++)
		{
			deckptr->suitValue=i;
			deckptr->faceValue=j;
		}
		deckptr++;
	}
}

this is what comes out:
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾
A--¢¾

Is filldeck() wrong or is it my loop that prints out? Thanks for the help

yeah so i dont know why but the cents 3/4 symbol is a heart in the output. thanks.

yah i would like to just pass filldeck an array, but its mandatory that i pass it the pointer so... whatever. Thanks quzah

i got it working, but now i have another question:

allright so i need a function to shuffle a deck of cards with its only parameter being deckptr:

I was thinking i could find two random numbers ( rand()%52 ) then switch their places in the array( in a loop ) but i got confused trying to write it. Would there be an easier or a more efficient way? thanks all.

I didn't test this, but feel free to use it if it works.

Code:

shuffle(Card *deckptr){
    Card aux[52];
    int x, y, m = 52 / 2;

    for (x = 0, y = 0; x < 52; x += 2, y++){
        aux[x] = deckptr[y];
        aux[x + 1] = deckptr[m + y + 1];
    }

    for (x = 0; x < 52; x++)
        deckptr[x] = aux[x];
}

this is what i came up with and it seems to work fine:

Code:

void shuffleDeck(card *deckptr)
{
	card temp, *crdptr;
	int i,num;

	for(i=0;i<53;i++)
	{
		num=rand()%52;
		crdptr = deckptr + num;

		temp = *crdptr;
		*crdptr = *deckptr;
		*deckptr = temp;

		deckptr + 1;
	}
}