Thread: Arrays & functions

So, what's your question?

The call should look like this:

getstring ( desc );

The functions should look like this:

Code:

/* Very bad code, but that's life. ;) */
void getstring(char desc[])
{
  puts("\tEnter the description : ");
  fflush(stdin);
  gets(desc);
  upcase(desc);
}

void upcase(char *s1)
{ 
  while(*s1)
    *s1++ = toupper(*s1);
}

Since you are obviously using a compiler that fflush works for input streams, it will suffice for your homework. But keep in mind that the C standard defines fflush for output streams, so fflush ( stdin ) is undefined whether it works or not. And you should consider using fgets instead of gets, it will check your array boundaries instead of overwriting memory you don't own. I won't bother detailing the flaws in your code since your instructor should be doing that, if she/he doesn't then come back and I'll be glad to give you a detailed description as well as ways to improve.

-Prelude

@Shila:
Well, there are arrays everywhere. Please, tell us the name of the function!

Code:

switch (key)
{
    case '1': case 'A': add(); break;
    case '2': case 'R':
    case '3': case 'D':
    case '4': case 'C': ("\nNot Implemented"); break;
    case '5': case 'Q': more = FALSE; break;
    default : ("\nError in selection\a");
}

Is the code above a valid switch/case construct?
And btw never forget to end each 'case' statement with break;.
And in line 96 delete the second semicolon at the end of the line.

Line 84 should look like this:

Code:

getstring(desc);

This is my suggestion for your nemesis functions:

Code:

void getstring(char desc[])
{
    puts("\tEnter the description : ");
    gets(desc);
    upcase(desc);
    puts(desc);
}
void upcase(char s1[])
{ 
    while(s1 && (*s1 != '\0'))
    {
        *s1 = toupper(*s1);
        s1++;
    }
}

I didn't test the code ... it may not work.

@Prelude:
Oh, I am very sorry! You already did the code for the two functions above!