needs a correction

Code:

#include<stdio.h>

int level(int n);

main ()
{
	int a, i;                                          /* i is used for the FOR-LOOP */
   for(i=0;i<15;i++)                                       /* i is counted to 15 */
	printf("this displays simple function calls:\n");  
   printf("%d", level(i));                                 /* this line calls an integer, calling the value of i */
   scanf("%d", a);
}
int level(int n)                                           /* the value of i is copied to n */
{
   	n=n+2;                                             /* the value of n is increased by 2 */
   return n;                                               /* n is returned to the function call, replacing i */
}

please correct me, if the comments are wrong and i understood the code the wrong way.

thanks

Your scanf call is incorrect. You need to use the address of the variable (ie: a pointer) to use scanf. As such:

scanf( "%d", &a );

That's what you want. You are also slightly misunderstanding your return value:

Code:

int func( int n )
{
    return n+2;
}

Here you're not replacing anything. You are simply returning a value. What you do with that value is up to you. If you want it to end up "replacing" the parameter you pass to it, you need to actually assign the value back to the variable you pass to it. This is how you do that:

int i;
i = 5;

i = func( i );

Thus, you pass the value in 'i' to the function, and when it is returned, it gets assigned back to 'i'.

Quzah.

Originally posted by threahdead

Code:

#include<stdio.h>

int level(int n);

main ()
{
	int a, i;                                          /* i is used for the FOR-LOOP */
   for(i=0;i<15;i++)                                       /* i is counted to 15 */
	printf("this displays simple function calls:\n");  
   printf("%d", level(i));                                 /* this line calls an integer, calling the value of i */
   scanf("%d", a);
}
int level(int n)                                           /* the value of i is copied to n */
{
   	n=n+2;                                             /* the value of n is increased by 2 */
   return n;                                               /* n is returned to the function call, replacing i */
}

please correct me, if the comments are wrong and i understood the code the wrong way.

thanks

because it has no braces of its own, the for loop only runs the highlighted statement 15 times, then it continues on and runs everything else once. i'm not sure if this is what you want.

i needed to know if i understood the lines correctly, because its a program of my own.
i have written down my thoughts to this program in the comments, i wanted you to correct these lines if they are not correct.

thanks for the help i noticed something new

threadead, that's not how you want to comment code. You want to put in comments such as what the program/function is trying to accomplish. Comments such as "n is increased by 2" has no meaning and anyone who reads the line n=n+2 already knows that.

Anna, you can do a search and find your old thread. Or you can search for your previous posts. You only have 8 of them so how hard would it be to find it?

Originally posted by Cshot
threadead, that's not how you want to comment code. You want to put in comments such as what the program/function is trying to accomplish. Comments such as "n is increased by 2" has no meaning and anyone who reads the line n=n+2 already knows that.

I think they were only commenting that way to tell us what they thought the code did, and were asking if what they thought it did was correct. I don't think they were commenting that way for the sake of general comments.

Quzah.