Help!

[cj1]

help with code
the user is suposed to type

PRINT EXAMPLE

AND IT SHOULD PRINT
EXAMPLE

#include "conio.h"
#include "stdio.h"
int main()
{   
int array[100],i; 
  printf("array[]:"); 
  scanf("%s",&array);  
 if(array[0]=='P')   {  while (array[i]>1)   
{  
 printf("%u",array[i]);   i++; 
  }  
  }   getche(); 
  return 0;}

Code tags added by kermi3

[moi]

ugg put some code tags on that mess

and a %s code in scanf expects an argument of type

char *

but you give it an argument of type

int **

[kermi3]

I am posting this because you did not use code tags on this thread. In the furture please use Code Tags. They make your code MUCH easier to read and people will be much more likely to help you if you do. And they'll be happy about helping you


For example:

Without code tags:

for(int i=0;i<5;i++)
{
cout << "No code tags are bad";
}

With Code Tags:

for(int i=0;i<5;i++)
{
     cout << "This code is easy to read";
}

This is of course a basic example...more complicated code is even easier to read with code tags than without.

I've added code tags for you this time. They can be added by putting [code] at the beginning of your code and [/code] at the end. More information on code tags may be found at the link in my signature. Any further questions or ways I can help please feel free to PM me.

I hope this helps, and good luck,

Kermi3

[quzah]

int array[100],i; 
    printf("array[]:"); 
    scanf("%s",&array);  
    if(array[0]=='P')   {
        while (array[i]>1)   
        {  
             printf("%u",array[i]);   i++;

So what you have is:

for( i = some random number; i > 1; i++ )

Does this make sense to you? Do you see why this wouldn't work?

1) You never initialize 'i', so it has some totally random value.
2) You check to make sure 'i' is greater than 1, and if so...
3) You INCREMENT 'i'??

Quzah.

[moi]

Originally posted by quzah
So what you have is:

for( i = some random number; i > 1; i++ )

Does this make sense to you? Do you see why this wouldn't work?

1) You never initialize 'i', so it has some totally random value.
2) You check to make sure 'i' is greater than 1, and if so...
3) You INCREMENT 'i'??

Quzah.

well, assuming some 100% random value is stored in i, 50% of the time it will be negative, so nothing to worry about; if it doesnt work just run it again!

further elaboration on the scanf cj1:

when you use the %s scanf code it will read a string into a char array. you have declared an int array, and then you take the address of a pointer to the first element in that array. no. i don't even want to think about the possible mishaps of running this

try:

char array[100];
scanf ("%s", array); // or &array[0]