why?

[threahdead]

hi
im pretty new to c programming.

so would please anyone of you tell me whats wrong with this code?

#include <stdio.h>
#include <stdlib.h>

main ()
{

printf ("type 'hello'.\n");
scanf ("%ld");
}
{
if scanf == 'hello';
printf ("correct\n");
else
printf ("wrong!\n");
getch();
}


the purpose of this code is very simple.

the user types in the word 'hello', if he does so the output 'correct' should appear.
in any other case there should pop a 'wrong'.

thanks for the help
cya threadhead

[Stoned_Coder]

just about everything is wrong with it.

here it is fixed for you. Compare my version to yours and see your errors...

#include<stdio.h>
#include<string.h>
int main()
{
char buffer[256];
printf("Type hello\n");
scanf("%s",buffer);
if (strcmp(buffer,"hello")==0) printf("Correct\n");
else printf("wrong\n")
return 0;
}

[Prelude]

#include <stdio.h>
#include <stdlib.h>

/*
** main returns an int, this should be
** int main ( void )
*/
main ()
{

printf ("type 'hello'.\n");
/*
** scanf must have a variable to write to, this is undefined.
** Also, the ld flag is for long integers, not strings.
*/
scanf ("%ld");
/*
** This closes main. Not what you want.
*/
}
/*
** Illegal block.
*/
{
/*
** You cannot test scanf like this and strings are surrounded
** by double quotations, not single.
*/
if scanf == 'hello';
printf ("correct\n");
else
printf ("wrong!\n");
/*
** getch is declared in conio.h, yet you did not include it.
*/
getch();
}

This code fixed (somewhat) would look something like this:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <conio.h>

int main ( void )
{
  char word[10];

  printf ( "Type hello: " );
  scanf ( "%s", word );

  if ( strcmp ( word, "hello" ) == 0 )
    printf ("correct\n");
  else
    printf ("wrong!\n");

  getch();

  return 0;
}

-Prelude

[The Dog]

Frstly use int main() and return 0 at the end of main.

>> scanf ("%ld");
You'll need a variable to store the user-input.

eg.

char var[20];
scanf("%s", var);
//Note the "%s". The ",var" is there to tell the 
//compiler where you want the input stored.

>if scanf == 'hello';
You have to compare strings using a string comparison function of some sort. You can include string.h and use strcmp().
eg.

#include <string.h>
..
..
if( strcmp(var,"hello") == 0) //They'll be equal if strcmp() returns 0
    printf ("correct\n");
else
    printf ("wrong!\n");

Also, you're using getch() without including conio.h.

[crag2804]

Here's an ugly way of doing it:

#include <stdio.h>
#include <string.h>

int main ()
{
char typed [10];
char compare [10] = "hello";
printf ("type 'hello':\n");
scanf ("%s",&typed);
if (strcmp (typed,compare) == 0){
	printf("correct");
   }
else {
	printf("wrong");
   }
   return 0;
}

Hope this helps

[threahdead]

thanks for the maybe fastest help on earth

cya threadhead