variables

[Unimatrix139]

If I define a variable in a procedure, can I call the procedure again and again without problems? I am using code like this:-

void func02()
{
   char buffer[700]
   strcpy(buffer, "Test");
   printf("The value of buffer is %s\n", buffer);
   nextfunc();
}

When I run my application, a stack overflow always occours after accessing this procedure about 7 times. Is the variable (buffer) causing the problems? Thanks

[Prelude]

>a stack overflow always occours
It may be a contributing factor, what does nextfunc() do?

>char buffer[700]
>strcpy(buffer, "Test");
This looks like a test program, but this is a terrible waste of space.

-Prelude

[Unimatrix139]

Its just an example of what me program does. The real thing goes like this:-

prompt()
{
   char buffer[1000];
   int i;
   if(promptr!=NULL)
   {
      printf("%s ", promptr);
   }
   inputstr=gets(sizedstring1);
   if(strlen(inputstr)>692)
   {
      error3(41, NULL);
      prompt();
   }
   starstring=inputstr;
   if(strcmp(starstring, "\n")!=0) { fprintf(perm, "%s\n", starstring); }
   if(privstat!=0)
   {
      i=0;
      do
      {
         buffer[i]=NULL;
         i=i+1;
      }
      while(i<sizeof(buffer));
      strcpy(buffer, "p=");
      strcat(buffer, starstring);
      starstring=eciread("[ACCESS]", buffer, 700, 0, 1);
      if(starstring!=NULL)
      {
         error3(40, NULL);
         prompt();
      }
   }
   process(inputstr, 1, 1);
}
void process(char *processr, int a, int b)
{
   if(b==1) { refresh(0); }
   if(k==1)
   {
      stdint1=0;
      fp=fopen("~tmp01.tmo", "a");
      while(stdint1<2000)
      {
         peek(0, stdint1, starstring, 54);
         fprintf(fp, starstring);
         stdint1=stdint1+1;
      }
      starstring=NULL;
      stdint1=0;
      fclose(fp);
   }
   if(strncmp(processr, "", 1)==0)
   {
      if(a!=2) { prompt(); }
   }
   /* more strncmp statements all branching off to different procedures */
   prompt();
}

[Salem]

Rewrite it using a while loop in prompt(), so that if the user gets it wrong, or wants another go, then you just repeat the while loop

Ditto with process(), this should just return to prompt() for another iteration of the process, not call prompt() recursively

[Unimatrix139]

Good idea - i'll re-write both of them with loops instead. Thanks Salem and Prelude