Thread: extraction

Just by glancing over it , you never increment your k variable in the while loop. I don't know if that will fix all of your problems, but it is a start.

As i've learned from this forum you should use "fgets" instead of "gets".

You have the right idea but it can be done with a lot less code(work).

Here's some streamlined code that will do what you want. If you have questions post another thread.

Code:

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
 int n=0;
 char input[BUFSIZ];

 printf("Input characters: "); 
 if(fgets(input,BUFSIZ,stdin)!=NULL)
 {
  sscanf(input, "%s", input);
 }

 // parse the string printing vowels only
 while(input[n++]!='\0')
 {
  switch(input[n])
  {
   case 'a': case 'e': case 'i': case 'o': case 'u':
   printf("%c", input[n]);
   break; 

   default:
   break; 
  } // end switch(input[n])
 } // end while(input[n]!='\0')

 return EXIT_SUCCESS;
} // end int main(void)

Code:

char *strip_consonants(char *input)
 {
   if( input == NULL) return input; //...return to sender ;)
  
   int len = strlen(input), i, t;

   char temp[len];

   strcpy(temp, input);

   for(i = 0, t = 0; t < len; t++)
     switch( tolower(temp[t]) )
      {
         case 'a': 
         case 'e': 
         case  'i': 
         case 'o': 
         case 'u': 
         input[i++] = temp[t];
         break;        
      }

     input[i] = 0;

return input;
 }



int main(){

char answer[] = "Answer is found";

printf( "Answer: %s", strip_consonants(answer) );

getch();

return 0;
}

> sscanf(input, "%s", input);

Good call. And you know, I just plain hate scanf. I realize sscanf is prolly more reliable with strings, but scanf is simply buggy! I always prefer fgets(). I'm done

> string[k]=='a'||'e'||'i'||'o'||'u'

That seemed wrong to me too, but somewhere in the back of my mind I remember a variation similar to the above syntax. Am I delusional?

Geez, you'd think I'd stop doing that, sorry. But hey, no offense Salem, but I think YOU are in the minority insofar as compilers are concerned! I am tempted to take a poll! Salem, C++ is here to stay. The line between the two is blurring! Let's enjoy it's wonderful features - eh?

Note that sscanf isn't an ordinary method or built-in function, but a very special construction in Pike. The reason is that sscanf has to change its arguments, and since Pike uses call-by-value, no ordinary method or built-in function can do that.

Certainly in this case it may not be necessary but I use it because
it always guarantees a properly terminated string.

But I don't mind the criticism, keeps me on my toes and as I've found out in this forum after 20 years of programming C I still have a lot to learn!

Max, if you're going to ask for advice, best you listen a little harder to it. Look:

Originally posted by jerryvtts
As i've learned from this forum you should use "fgets" instead of "gets".

So come on, stop using gets() in your code, it's not good!

Now if you really want to add things to a string (char array), you could use strncat(), or you could write directly to each byte. Just make sure not to go past the end of the buffer.

Also, this isn't going anywhere:
>while(input[n++]!='\0')
>{
>switch(input[n])
You incremented n on the while line, then used it's new value on the switch line. So at the start of the execution, the while changes n from 0 to 1, and the switch never sees n as being 0.