Prog won't work after i press enter...

ok its a password prog...when i type the password and press enter nothing happens....whats wrong?

Code:

/***  password lit un mot de passe sans l'afficher à l'écran et vérifie,    ***/
/***  via la fonction "strlen", si on n'a pas dépassé une certaine longueur ***/
/***  maximale prédéfinie                                                   ***/

#include <stdio.h>                                             /* pour printf */
#include <conio.h>                                      /* pour getche, getch */
#include <string.h>                                    /* pour strlen, strcpy */

main()
{
    char buffer[81];                                 /* pour ranger la saisie */
    char pword[9];                                            /* mot de passe */
    char reply, new, i;                              /* Variables de contrôle */

    do
      {

         printf("Entrez un mot de passe (8 caractères au plus) : ");

         i = 0;
         while ((buffer[i] = getch()) != '\n')       /* lecture du mot de passe */
               i++;
         buffer[i] = '\0';                                  /*  caractère nul */

         if (strlen(buffer) > 8)                 /* si mot de passe trop long */
            {
               printf("Mot de passe trop long.\n");
               printf("<Entrée> pour nouvelle saisie. Fin par <ECHAP>.\n");
               new = getche();
            }
         else                                         /* mot de passe correct */
            {
               strcpy(pword, buffer);               /* mémoriser mot de passe */
               printf("\nMot de passe enregistré. Visualisation ? (o/n) ");
               if ((reply = getche()) == 'o')
                   printf("\nVotre mot de passe est \"%s\"\n", pword);
                   new = 27;      /* pour finir do while, new doit recevoir 27 */
            }
         } while (new != 27);                     /* tant que nouvelle saisie */
}

thanks

> while ((buffer[i] = getch()) != '\n')

Just use fgets. With your code, I can overflow your buffer and crash your program.

The real problem is with your using 'getch'. This hangs the program. Use 'getchar ', or 'fgetc(stdin) ', or 'getc '.

Quzah.

if i change this while ((buffer[i] = getch()) != '\n') to this while ((buffer[i] = getchar()) != '\n') we can see the password...and i dont want that... what should i do? sorry im not really good in programming.

You could always the search button?

Quzah.

well i changed while ((buffer[i] = getch()) != '\n') to while ((buffer[i] = getch()) != '\r') and it works so im happy with that thanks for your help.

Originally posted by emperor
well i changed while ((buffer[i] = getch()) != '\n') to while ((buffer[i] = getch()) != '\r') and it works so im happy with that thanks for your help.

Really? That's interesting to note. Is this on a MS based operating system? I'll have to try it here.

IIRC, the '\r' is used in MS(read: dos/windows) OSs in conjunction with the '\n' character to denote a newline/carriage return. Mac's only use '\r', and *NIX only use '\n'. Again, I might be slightly off, but IIRC that's how it goes...

Anyway, it's interesting to know.

yep im on windows xp

Originally posted by emperor
yep im on windows xp

Nod. Have you seen the (I think it's two lines?) simple code that will crash XP? I've yet to try it, and have been meaning to do so:

In a nut shell, it's something like:

Code:

for(int i = 0; i < 5 ; i++)
    printf("\t\t\b\b\b");

Some people have to make it more than a loop of 5. I'm not sure why it does it... Just another interestingly odd thing.

Quzah.

yeah it works, it reboots my comp.