Missing out lines

[Inept Pig]

When using the following code I have a problem with the fact that, during running the program, it skips the entire enter date section and just prints the next line, not allowing for any input, most frustrating... the code is:


printf("Enter customer name: ");
scanf("%s", job.club);
printf("Enter job number: ");
scanf("%s", job.job_num);
printf("Enter job date: ");
scanf("2%d", job.job_date.day);
scanf("2%d", job.job_date.month);
scanf("4%d", job.job_date.year);
printf("Enter fault code: ");
scanf("%s", job.f_code);
printf("Enter any comments: ");
gets (job.comments[200]);


Thanks in advance for any help/advice..

[quzah]

scanf("%s", job.club);

Is this a pointer with allocated space?
If not, you're using scanf wrong.

printf("Enter job number: ");
scanf("%s", job.job_num);

Is this a pointer with allocated space?
If not, you're using scanf wrong.

printf("Enter job date: ");
scanf("2%d", job.job_date.day);

Is this a pointer with allocated space?
If not, you're using scanf wrong.

scanf("2%d", job.job_date.month);

Is this a pointer with allocated space?
If not, you're using scanf wrong.
Repeat ad-nausium.

Quzah.

[Prelude]

>scanf("%s", job.club);
The scanf function being irresponsibly used with string data...I know that I've warned about this many times in the past. Friends don't let friends use scanf for user input, so I'll offer fgets as an alternative.

>scanf("2%d", job.job_date.day);
>scanf("2%d", job.job_date.month);
>scanf("4%d", job.job_date.year);
I'd bet my next paycheck that these structure members are not pointers.

>gets (job.comments[200]);
This really isn't much better.

First, I'd recommend that you read up on scanf and gets before using them further. Then read all previous posts on the problems that they can cause. Then, if you still feel the desire to use them for some strange reason, you'll at least be in a better position to use them as correctly as they can be used.

-Prelude

[Inept Pig]

Aaaaah... Thanks for the advice...

And I promise never to post another program using scanf for user input... lesson learned...

[Prelude]

>And I promise never to post another program using scanf for user input...
Using scanf for very simple user input such as a single integer is fine. The problem is that scanf was designed for formatted input and users never format their input correctly, so you end up dealing with more problems than necessary.

-Prelude