Thread: Calc Problem.

Whats wrong with this code? It compiles fine but when I run it I type in the first # and it crashes...

main()
{
float first,second,exit,equal;

printf("Please Enter The # You Want Added : ");
scanf("%d",first);
printf("Please Enter The Second # : ");
scanf("%d",second);
equal=first+second;
printf("\nThe Answer to %d + %d = %d",first,second,equal);
printf("This Program is finished. If you would like to quit type End and press enter now.");
scanf("%d",exit);
}

exit is a float and you enter END? Also, why are you using %d with floats?

umm the reason your program is crashing is probably because your not saving the read in int, double whatever using the memory address, you've got:

Code:

main() 
{ 
float first,second,exit,equal; 

printf("Please Enter The # You Want Added : "); 
scanf("%d",first); 
printf("Please Enter The Second # : "); 
scanf("%d",second); 
equal=first+second; 
printf("\nThe Answer to %d + %d = %d",first,second,equal); 
printf("This Program is finished. If you would like to quit type End and press enter now."); 
scanf("%d",exit); 
}

and it should be:

Code:

main() 
{ 
float first,second,equal,exit;

printf("Please Enter The # You Want Added : "); 
scanf("%f",&first); 
printf("Please Enter The Second # : "); 
scanf("%f",&second); 
equal=first+second; 
printf("\nThe Answer to %f + %f = %f",first,second,equal); 
printf("This Program is finished. If you would like to quit type End and press enter now."); 
scanf("%f",&exit); 
}

also I'm not sure what your trying to do with the last few lines, you should be using a string and doing a strcmp to see if they typed end. Hope this helps

Thanks, really.
and it may look sloppy the way I end it but
heres my reasoning
When I was learning I was doing the hello world and it would just close but then I saw scanf and that would stop it becuase not all the funtions were done so I got used to it plus Ive been programming for 'bout a week so I dont have eveything down.
like I forgot that you call float different then int and char ect.