errr, is my code "good" ?

This is a discussion on errr, is my code "good" ? within the C Programming forums, part of the General Programming Boards category; Take a look at my source code. Any large errors? Is my modularization poor form, or is there a way ...

  1. #1
    Unleashed
    Join Date
    Sep 2001
    Posts
    1,765

    errr, is my code "good" ?

    Take a look at my source code.

    Any large errors?
    Is my modularization poor form, or is there a way I can make it better?
    Attached Files Attached Files
    The world is waiting. I must leave you now.

  2. #2
    and the hat of wrongness Salem's Avatar
    Join Date
    Aug 2001
    Location
    The edge of the known universe
    Posts
    32,337
    ZipCheck doesn't do anything - in particular, it doesn't return pass/fail back to the caller.

    FileCopy is randomly indented, which seems to be caused by using spaces and tabs to indent with.
    Nearly every editor can change the tab width, but the only way to be sure your code stays looking nice is to use spaces.

    These two lines do not need the {} and the indentation, which makes them seem part of a while statement.
    fclose ( out );
    printf("\nCopied: %s\n", Display);

    A more consistent function naming style would help - you have at least 3 styles of caps/underscores
    void full_screen(void);
    void clrscr(void);
    void PcGames(void);

    install.h
    > int SetColor( Color );
    This prototype is inconsistent with the rest, which also have a name for the parameter, not just a type

    Also, including header files inside header files can be bad. You've traded short-term easy typing with a long term maintenance problem.

    The only header file I would include in install.h would be the header file which contained the declaration of the Color type (as used by SetColor).

    It hides dependencies. Not only does this make it difficult to figure out whether 'a' depends on 'b', it also makes it easy to generate needless dependencies by accident. It's simply way too easy to put something in the wrong place and have it compile.

    It increases compile times - everything includes everything.

    Personally, I would make each .c file have its own .h file. I know its cumbersome to include half a dozen (or more) .h files at the start of each .c file, but you'll know where everything is, and how and where to put new stuff.

    In your case, only the main function will include everything. Each component source file will only include what is necessary to make it compile.

    It also forces you to think a bit more about how the code is structured, and to keep thinking about it as the program develops.

    As far as the placement of functions inside files goes, it seems OK to me

  3. #3
    Unleashed
    Join Date
    Sep 2001
    Posts
    1,765
    Thank you salem, for all of your tips.
    The world is waiting. I must leave you now.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Extended ASCII Characters in an RTF Control
    By JustMax in forum C Programming
    Replies: 18
    Last Post: 04-03-2009, 08:20 PM
  2. Enforcing Machine Code Restrictions?
    By SMurf in forum Tech Board
    Replies: 21
    Last Post: 03-30-2009, 07:34 AM
  3. Values changing without reason?
    By subtled in forum C Programming
    Replies: 2
    Last Post: 04-19-2007, 10:20 AM
  4. Interface Question
    By smog890 in forum C Programming
    Replies: 11
    Last Post: 06-03-2002, 05:06 PM
  5. Replies: 0
    Last Post: 02-21-2002, 05:05 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21