Thread: Bored Coders

Can anyone tell me why the output here is garbled?

It's supposed to place words in one container, everything else in the next, so on and so on till the array of structures is filled. Instead, well, compile for yourself and see!

Code:

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>



typedef struct temporary
{
char t[25];
};




int main()
{


char buffer[]="   This is 1very long sentence. It may be boring 4 you to read, and you may care < about what it says but it is #1 for Testing!!!";




int start_word, u = 0;
int count=0;

///////////// First Count ///////////////////////////

if( isalpha(buffer[0])  ){start_word = 0;}         // <---Precondition
else if( !isalpha(buffer[0])  ){start_word = 1;}  // <---

for( yy = 0; yy< strlen(buffer);yy++)
{


if( start_word == 0)
{


 if( !isalpha(buffer[yy]) )
  {
   start_word = 1;
   count++;
  }
}

else if( start_word == 1)
{


 if( isalpha(buffer[yy])   && buffer[yy] != '\n'  )
  {

    start_word = 0;
    count++;
  }
}
 }
/////////////// End Counting ///////////////////////

char tem[25];

struct temporary temp[count];   <---use count

int s = 0;



if( isalpha(buffer[0])  ){start_word = 0;}         // <---Precondition
else if( !isalpha(buffer[0])  ){start_word = 1;}  // <---

for( yy = 0; yy<  strlen(buffer);yy++) 
{


if( start_word == 0)
{



 if(  isalpha(buffer[yy])   )
  {
   tem[u] = buffer[yy]; u++;
  }


 if( !isalpha(buffer[yy])    )
  {

   ///tem[u-1] = '\0';
   strcpy(temp[s].t,tem);
   start_word = 1;
   u = 0;
   s++;
   strcpy(tem,"");
  }
}

else if( start_word == 1)
{


 if( !isalpha(buffer[yy])    )
  {
   tem[u] = buffer[yy]; u++;
  }


 if( isalpha(buffer[yy])    )
  {
   ///tem[u-1] = '\0'; <--didn't help
   strcpy(temp[s].t,tem);
   start_word = 0;
   u = 0;
   s++;
   strcpy(tem,"");
  }
}
 }




for(i=0;i<count;i++){ printf("%s",temp[yy].t);  getch(); }


return 0;
}

Okay, here's some stuff...
1) Did you declare yy before you used it? I can't see it, but I'm inclined to think you did because otherwise it shouldn't compile.

2)

Code:

for(i=0;i<count;i++){ printf("%s",temp[yy].t);  getch(); }

I'm pretty sure there's your problem, since at the time this line is called, yy = strlen(buffer), which is generally bad. I haven't comiled the code, but what I'm guessing is you're getting a long string of meaningless characters (possibly not), and you just keep getting the same characters every time you hit a key, for count times.

EDIT: This is probably a good time to point out a pretty good rule of thumb. When your output is meaningless, the problem is usually your output routine reading from the wrong memory. If the problem was in your input routine, the program would just crash, and if it were the logic of your program, it'd either crash, or you'd get wrong, but meaningful answers....
This is just a rule of thumb however.

Sorry, I'm using the macro "#define forr(n) for(yy=0;yy<n;yy++)" and replaced it with the "i" loop in the post so as not to confuse. But yes, all is being declared, it just doesn't work correctly. The logic of the code seems pretty straight-forward to me but apparently I'm wrong...