Thread: C program crashed

this is my program.

Code:

#include<stdio.h>
#include<conio.h>
struct abc
{
 char name[20];
 int day;
 char month[10];
 int year;
 float salary;
};

 void main()
 {
 struct abc person[10];
 //float totalsalary=0;
 int n,i,t;
 char month[12];
 clrscr();
 printf("enter number of employees\n");



 scanf("%d",&n);
 printf("number of employee =%d\n",n);

 for(i=0;i<=n;i++)
 {
  printf("input values\n");
  scanf("%s %d %s %d %f",person[i].name,&person[i].day,person[i].month,&person[i].year,&person[i].salary);
//  printf("%s %d %s %d %f\n",person[i].name,person[i].day,person[i].month,person[i].year,person[i].salary);


 }
 /*
 printf("enter the month for totalsalary");
 scanf("%s",month);

 for(i=0;i<=n;i++)
 {
  t=strcmp(person[i].month,month);
  if(t==0){
     totalsalary=totalsalary+person[i].salary;
  }
 }


printf("the totalsalary for giving moth = %f",totalsalary);  */
getch();
}

enter number of employees
2

number of employee =2

input values
Test 23 january 2012 6700 //Enter pressed

Now It goes back to turbo c++ editor

what I'm doing wrong ?

Your main problem is TurboCrap. Stop using it!

Well the first thing you're doing wrong is using a compiler from the stone age.

Second, your output doesn't agree with your code.
> printf("number of employee =%d\n",n);
Did you see this?
Make sure you're compiling and running your latest edit.

Third, for(i=0;i<=n;i++) runs n+1 times, not n times.
So when you get around to typing in 10, you overflow your array.

Then there's the whole void main issue as well.

Originally Posted by Salem

Second, your output doesn't agree with your code.
> printf("number of employee =%d\n",n);
Did you see this?

yes .. it prints 2 when I input 2.

Make sure you're compiling and running your latest edit.

Yes

Third, for(i=0;i<=n;i++) runs n+1 times, not n times.
So when you get around to typing in 10, you overflow your array.

Then there's the whole void main issue as well.

Okay.

I changed to

Code:

 for(i=1;i<=n;i++)

but same result...It did not work

so whats the issue here ? Why my program did not work. What to fix ?


updated code

Code:

#include<stdio.h>
#include<conio.h>
struct abc
{
 char name[20];
 int day;
 char month[10];
 int year;
 float salary;
};

 void main()
 {
 struct abc person[10];
 //float totalsalary=0;
 int n,i,t;
 char month[12];
 clrscr();
 printf("enter number of employees\n");



 scanf("%d",&n);
 printf("number of employee =%d\n",n);

 for(i=1;i<=n;i++)
 {
  printf("input values\n");
  scanf("%s %d %s %d %f",person[i].name,&person[i].day,person[i].month,&person[i].year,&person[i].salary);
  printf("%s %d %s %d %f\n",person[i].name,person[i].day,person[i].month,person[i].year,person[i].salary);


 }
 /*
 printf("enter the month for totalsalary");
 scanf("%s",month);

 for(i=0;i<=n;i++)
 {
  t=strcmp(person[i].month,month);
  if(t==0){
     totalsalary=totalsalary+person[i].salary;
  }
 }


printf("the totalsalary for giving moth = %f",totalsalary);  */
getch();
}

Well changing to starting at 1 fixes the number of loop iterations, but doesn't fix your array overrun issue.
Array subscripts start at 0, and finish at n-1.

Another problem is that your array is on the stack, and probably takes 300 to 400 bytes.
Your archaic compiler with it's 16-bit world is probably running out of stack space. The default stack was very small IIRC.

You might try making your person array global to save blowing your meagre stack away.

But it's just putting lipstick on a pig IMO.

Originally Posted by Salem

Your archaic compiler with it's 16-bit world is probably running out of stack space. The default stack was very small IIRC.

You might try making your person array global to save blowing your meagre stack away.

Does this mean to put person array outside main() ?

Yes.