What do you think of this digital clock?

Any things done wrong in it? Any way to do it better?
I did it in about 5 minutes or so out of bordem.
It's not necessarily a typical programming question.

Code:

---

#include <time.h>
#include <stdio.h>
#include <windows.h>

int clrscr()
{
    COORD coordScreen = { 0, 0 };
    DWORD cCharsWritten;
    CONSOLE_SCREEN_BUFFER_INFO csbi;
    DWORD dwConSize;
    HANDLE hConsole = GetStdHandle(STD_OUTPUT_HANDLE);

    GetConsoleScreenBufferInfo(hConsole, &csbi);
    dwConSize = csbi.dwSize.X * csbi.dwSize.Y;
    FillConsoleOutputCharacter(hConsole, TEXT(' '), dwConSize, coordScreen, &cCharsWritten);
    GetConsoleScreenBufferInfo(hConsole, &csbi);
    FillConsoleOutputAttribute(hConsole, csbi.wAttributes, dwConSize, coordScreen, &cCharsWritten);
    SetConsoleCursorPosition(hConsole, coordScreen);
    return 0;
}

int wait_a_moment ( int seconds )
{
    time_t hold_time;
    clock_t endtime = clock() + seconds * CLOCKS_PER_SEC;
    while ( ( clock() < endtime ) );
    hold_time=time(NULL);
    clrscr();
    printf(ctime(&hold_time));
    return 0;
}

int full_screen()
{
    keybd_event(VK_MENU,0x38,0,0);
    keybd_event(VK_RETURN,0x1c,0,0);
    keybd_event(VK_RETURN,0x1c,KEYEVENTF_KEYUP,0);
    keybd_event(VK_MENU,0x38,KEYEVENTF_KEYUP,0);
    return 0;
}

int kill_cursor()
{
    CONSOLE_CURSOR_INFO cci;
    cci.dwSize = 1;
    cci.bVisible = FALSE;
    SetConsoleCursorInfo( GetStdHandle( STD_OUTPUT_HANDLE ), &cci );
    return 0;
}

int main()
{
    time_t hold_time;
    clrscr();
    full_screen();
    kill_cursor();
    hold_time=time(NULL);
    printf(ctime(&hold_time));
    while(wait_a_moment(1) == 0);
    return 0;
}

---

wow really nice, I should use this as a proof that boredom is a good thing, it leads to creativity and solutions!

Hey Shadow, that looks pretty neat to me! :)

Only one small thing, my compiler (Borland 5.5) doesn't like function prototypes with no args, you have to use func(void). So I had to add the void's to your functions before I could compile it.

Good stuff though, I like the fullscreen bit, that's the kinda code I can have fun with!

:cool:

Ok, so i'll void all my functions that don't have arguments.
I "believe" that all of the functions in that program are all parts of other projects I'm working on for myself.
I was just browsing through my files and threw a couple of functinos together and BOOM!...digital clock.

Not bad, though you could gain a little bit more freedom in how you represent the clock by using a tm struct instance instead of just a time_t variable:

Code:

---

#include <windows.h>
#include <stdio.h>
#include <time.h>

void gotoxy ( int x, int y )
{
  COORD coord;
  CONSOLE_CURSOR_INFO c = { 1, 0 };
  coord.X = (short)x;
  coord.Y = (short)y;
  SetConsoleCursorPosition ( GetStdHandle ( STD_OUTPUT_HANDLE ), coord );
  SetConsoleCursorInfo ( GetStdHandle ( STD_OUTPUT_HANDLE ), &c );
}

int main ( void )
{
  struct tm *t;
  time_t now;
  for ( ; ; ) {
    now = time ( NULL );
    t = localtime ( &now );
    gotoxy ( 0, 0 );
    printf ( ( t->tm_sec % 2 ) ? "%d:%d" : "%d %d",
            t->tm_hour - 12, t->tm_min );
    Sleep ( 1000 );
  }
  return 0;
}

---

>my compiler (Borland 5.5) doesn't like function prototypes with no args
For good reason, for compatibility with K&R C, ANSI C allows function parameters to be declared empty. Note that an empty parameter list does not mean no parameters like it does in C++, that's what void does. In C an empty list means that there may be arguments, but the compiler doesn't know how many or of what type.

-Prelude