Thread: global const string vector

Originally Posted by bremenpl

But now the compiller warns me that that logLevelStrings is unused even though it is and it is compiling. Is it a correct aproach? I would apreciate help.

Didn't you intend to move 'dayOfTheWeek' to the header file instead of 'logLevelStrings'. Seems like you've moved the wrong struct definition.

Other than that, I personally don't have a problem with you moving the struct definition into the header file.

Also, looking at 'logLevelStrings', I would use an 'enum' to represent them other than strings.

I have edited my post, I pasted wrong struct, thank you.

I have an enum that represens days as numbers. that way I can reffer to them as indexes and do:

Code:

printf("the day is %s", dayOfWeekStrings[0]);

And it would print:

Code:

the day is Monday"

So static const definition in header file should be ok?

Thank you for the const hint, you are right i missed it!

As for the static- what would you say then, is the proper method of defining this const "structure" of data? I need this in the source file of the header, but also in other files including this header. I was wondering about creating a getter function for it, but it seemd to much for me. Could you please advice the proper way from designers point of view?

Using extern in the header declaration was appropriate. The source file where you implement the functions you use would then define this array with its content in global scope.

dates.h

Code:

#ifndef JCK_HEADER
#define JCK_HEADER

extern const char *const dayOfWeekStrings[7];

#endif

dates.c

Code:

#include "dates.h"

const char* const dayOfWeekStrings[7] =
{
    "Monday",
    "Tuesday",
    "Wednesday",
    "Thursday",
    "Friday",
    "Saturday",
    "Sunday"
};

/* ... */

main.c

Code:

#include <stdio.h>
#include "dates.h"

int main()
{
    size_t i;
    for (i = 0; i < sizeof(dayOfWeekStrings) / sizeof(dayOfWeekStrings[0]); ++i)
    {
        printf("%-15s", dayOfWeekStrings[i]);
    }
    putchar('\n');

    return 0;
}